From: Lee Jones <lee@kernel.org>
To: Daniel Mack <daniel.mack@holoplot.com>
Cc: linux-leds@vger.kernel.org, pavel@kernel.org, robh@kernel.org,
devicetree@vger.kernel.org, Daniel Mack <daniel@zonque.org>
Subject: Re: [PATCH v2 0/3] leds: is31f132xx: add support for is31fl3293
Date: Thu, 20 Nov 2025 10:44:16 +0000 [thread overview]
Message-ID: <20251120104416.GB1949330@google.com> (raw)
In-Reply-To: <20251120104224.GA1949330@google.com>
On Thu, 20 Nov 2025, Lee Jones wrote:
> On Fri, 14 Nov 2025, Daniel Mack wrote:
>
> > From: Daniel Mack <daniel@zonque.org>
> >
> > This is v2 of the series to support the is31fl3293 with the is31f132xx
> > driver.
>
> Please place the changelog in the patch itself, under the "---" markers.
>
> > It is now split into 3 parts and also addresses the removal of forward
> > declarations.
>
> I still see the forward declarations.
Oh wait. They are removed in a subsequent patch.
Breaking and repairing things in the same set is generally frowned upon.
Make the preliminary changes first, then you never need the prototypes.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2025-11-20 10:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 9:46 [PATCH v2 0/3] leds: is31f132xx: add support for is31fl3293 Daniel Mack
2025-11-14 9:46 ` [PATCH v2 1/3] dt-bindings: leds: add issi,is31fl3293 to leds-is31fl32xx Daniel Mack
2025-11-14 17:53 ` Conor Dooley
2025-11-14 9:46 ` [PATCH v2 2/3] leds: is31f132xx: add support for is31fl3293 Daniel Mack
2025-11-14 9:46 ` [PATCH v2 3/3] leds: is31f132xx: re-order code to remove forward declarations Daniel Mack
2025-11-20 10:42 ` [PATCH v2 0/3] leds: is31f132xx: add support for is31fl3293 Lee Jones
2025-11-20 10:44 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251120104416.GB1949330@google.com \
--to=lee@kernel.org \
--cc=daniel.mack@holoplot.com \
--cc=daniel@zonque.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.