All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
	Viresh Kumar <vireshk@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Frank Li <Frank.Li@nxp.com>,
	Laxman Dewangan <ldewangan@nvidia.com>,
	Jon Hunter <jonathanh@nvidia.com>,
	dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
	Johan Hovold <johan@kernel.org>
Subject: [PATCH 7/9] dmaengine: mmp_tdma: drop unnecessary OF node check in remove
Date: Thu, 20 Nov 2025 12:45:22 +0100	[thread overview]
Message-ID: <20251120114524.8431-8-johan@kernel.org> (raw)
In-Reply-To: <20251120114524.8431-1-johan@kernel.org>

The driver does not support anything but OF probe since commit
3b0f4a54f247 ("dma:mmp_tdma: get sram pool through device tree").

Commit a67ba97dfb30 ("dmaengine: Use device_get_match_data()") later
removed most remnants of platform probing except for an unnecessary OF
node check in remove().

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/dma/mmp_tdma.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/dma/mmp_tdma.c b/drivers/dma/mmp_tdma.c
index 6186b9dc5457..ba03321eeff7 100644
--- a/drivers/dma/mmp_tdma.c
+++ b/drivers/dma/mmp_tdma.c
@@ -554,8 +554,7 @@ static void mmp_tdma_issue_pending(struct dma_chan *chan)
 
 static void mmp_tdma_remove(struct platform_device *pdev)
 {
-	if (pdev->dev.of_node)
-		of_dma_controller_free(pdev->dev.of_node);
+	of_dma_controller_free(pdev->dev.of_node);
 }
 
 static int mmp_tdma_chan_init(struct mmp_tdma_device *tdev,
-- 
2.51.2


  parent reply	other threads:[~2025-11-20 11:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-20 11:45 [PATCH 0/9] dmaengine: drop unused module aliases Johan Hovold
2025-11-20 11:45 ` [PATCH 1/9] dmaengine: bcm2835: drop unused module alias Johan Hovold
2025-11-20 11:45 ` [PATCH 2/9] dmaengine: dw: " Johan Hovold
2025-11-20 13:50   ` Andy Shevchenko
2025-11-20 11:45 ` [PATCH 3/9] dmaengine: fsl-edma: " Johan Hovold
2025-11-21  3:23   ` Frank Li
2025-11-20 11:45 ` [PATCH 4/9] dmaengine: fsl-qdma: " Johan Hovold
2025-11-21  3:23   ` Frank Li
2025-11-21  3:27   ` Frank Li
2025-11-20 11:45 ` [PATCH 5/9] dmaengine: k3dma: " Johan Hovold
2025-11-20 11:45 ` [PATCH 6/9] dmaengine: mmp_tdma: " Johan Hovold
2025-11-20 11:45 ` Johan Hovold [this message]
2025-11-20 11:45 ` [PATCH 8/9] dmaengine: sprd: " Johan Hovold
2025-11-20 11:45 ` [PATCH 9/9] dmaengine: tegra210-adma: " Johan Hovold
2025-11-20 11:56   ` Jon Hunter
2025-11-22  9:30 ` [PATCH 0/9] dmaengine: drop unused module aliases Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251120114524.8431-8-johan@kernel.org \
    --to=johan@kernel.org \
    --cc=Frank.Li@nxp.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=jonathanh@nvidia.com \
    --cc=ldewangan@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vireshk@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.