From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
To: bhelgaas@google.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Manivannan Sadhasivam <mani@kernel.org>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: [PATCH] PCI: Add quirk to disable ASPM L1 for Sandisk SN740 NVMe SSDs
Date: Thu, 20 Nov 2025 21:16:01 +0530 [thread overview]
Message-ID: <20251120154601.116806-1-mani@kernel.org> (raw)
The Sandisk SN740 NVMe SSDs cause below AER errors on the upstream Root
Port of PCIe controller in Lenovo Thinkpad T14s laptop when ASPM L1 is
enabled:
pcieport 0006:00:00.0: AER: Correctable error message received from 0006:01:00.0
nvme 0006:01:00.0: PCIe Bus Error: severity=Correctable, type=Physical Layer, (Receiver ID)
nvme 0006:01:00.0: device [15b7:5015] error status/mask=00000001/0000e000
nvme 0006:01:00.0: [ 0] RxErr
Hence, add a quirk to disable L1 state for this SSD.
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
---
drivers/pci/quirks.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 214ed060ca1b..a6f88c5ba2f4 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -2525,6 +2525,18 @@ static void quirk_disable_aspm_l0s_l1(struct pci_dev *dev)
*/
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ASMEDIA, 0x1080, quirk_disable_aspm_l0s_l1);
+static void quirk_disable_aspm_l1(struct pci_dev *dev)
+{
+ pci_info(dev, "Disabling ASPM L1\n");
+ pci_disable_link_state(dev, PCIE_LINK_STATE_L1);
+}
+
+/*
+ * Sandisk SN740 NVMe SSDs cause AER timeout errors on the upstream PCIe Root
+ * Port when ASPM L1 is enabled.
+ */
+DECLARE_PCI_FIXUP_FINAL(0x15b7, 0x5015, quirk_disable_aspm_l1);
+
/*
* Some Pericom PCIe-to-PCI bridges in reverse mode need the PCIe Retrain
* Link bit cleared after starting the link retrain process to allow this
--
2.48.1
next reply other threads:[~2025-11-20 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 15:46 Manivannan Sadhasivam [this message]
2025-11-20 15:50 ` [PATCH] PCI: Add quirk to disable ASPM L1 for Sandisk SN740 NVMe SSDs Konrad Dybcio
2025-11-20 16:04 ` Manivannan Sadhasivam
2025-11-20 16:04 ` Lukas Wunner
2025-11-20 16:07 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251120154601.116806-1-mani@kernel.org \
--to=manivannan.sadhasivam@oss.qualcomm.com \
--cc=bhelgaas@google.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mani@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.