All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Nevo Hed via buildroot <buildroot@buildroot.org>
Cc: Nevo Hed <nhed+buildroot@starry.com>,
	Nevo Hed <nhed+github@starry.com>,
	Thomas Perale <thomas.perale@mind.be>
Subject: Re: [Buildroot] [PATCH] utils/generate-cyclonedx: fix monotonically increasing dependency list
Date: Thu, 20 Nov 2025 23:32:41 +0100	[thread overview]
Message-ID: <20251120233241.54d9b14b@windsurf> (raw)
In-Reply-To: <20251007174036.1178955-1-nhed+buildroot@starry.com>

Hello Nevo,

On Tue,  7 Oct 2025 13:40:35 -0400
Nevo Hed via buildroot <buildroot@buildroot.org> wrote:

> From: Nevo Hed <nhed+github@starry.com>
> 
> Having mutables as default args has unexpected behaviors.
> br2_parse_deps_recursively had a default arg `deps` initialized to the
> empty list (`[]`) except that on subsequent calls from `main` deps would
> already be populated from prior components.

Thanks for your patch! However in order to make it applicable, we need
you to add your Signed-off-by line.

Perhaps you could send a v2 of you patch with your Signed-off-by line
and the commit log extended with the reproduction details you shared as
a reply?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2025-11-20 22:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-07 17:40 [Buildroot] [PATCH] utils/generate-cyclonedx: fix monotonically increasing dependency list Nevo Hed via buildroot
2025-10-07 19:31 ` Nevo Hed via buildroot
2025-10-07 20:07 ` Thomas Perale via buildroot
2025-11-20 22:32 ` Thomas Petazzoni via buildroot [this message]
2025-12-02 21:34   ` Nevo Hed via buildroot
2025-12-03  7:46     ` Thomas Petazzoni via buildroot
     [not found] ` <20251226041452.1040838-1-nhed+github@starry.com>
     [not found]   ` <20251226041452.1040838-2-nhed+github@starry.com>
2025-12-26 19:55     ` [Buildroot] [PATCH v2 1/1] " Nevo Hed via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251120233241.54d9b14b@windsurf \
    --to=buildroot@buildroot.org \
    --cc=nhed+buildroot@starry.com \
    --cc=nhed+github@starry.com \
    --cc=thomas.perale@mind.be \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.