From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D361F34D3AD; Fri, 21 Nov 2025 13:40:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763732401; cv=none; b=kWcDeBM4/l2PwEzCLUMt8lfRs+RaHCGrnHKfBHrPAjBQClSeULV2KGiWTQgg6LJFTSukSXMq42t7j4tYw/DPxZO9nY9YIScGZztnCxEEX5XVbaj3sPI823zX46FXXdyw2l+0gtB12W30jYpKIUemzRO2cUtZq5WJfp4w0I3MFq4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763732401; c=relaxed/simple; bh=K27bVjyF8RPo5bLxWhrzZjWeSVPsrLk80pGASqMgX9o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iNupt8FG2sIpKib1fS0xJjBQIZXkrZd4N2U1kXjfWVZR5R6JAIdnnavArJfQ1X2cDcAWaj+j7etbN/MJCp68HpbCTiGMcrpAnWpVGYA2N8M+rUv0Z66N3IGQZocQi+kNUZaOyWApMxGQ+zM5eD/oavnfCy3BftggeXO/4RXP4vM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NX40f3ao; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NX40f3ao" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31478C4CEFB; Fri, 21 Nov 2025 13:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1763732401; bh=K27bVjyF8RPo5bLxWhrzZjWeSVPsrLk80pGASqMgX9o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NX40f3aoSHdpRG7sh9Fop5kkTIHUHDyVAEq96yHOLXlankx+HuzKkKNNCKUB1ARSe HZmFUBXbRv8PbqtLJkUNbpSJh0o0yhoDY3c6Jyw/mnr/H3SQkPDb1OLO/+i+HUNcIp Lo95UF/l7Aotp4jIsL7TMCaTqKEzMk4yUVGf37F0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Len Brown , Sasha Levin Subject: [PATCH 6.6 109/529] tools/power x86_energy_perf_policy: Enhance HWP enable Date: Fri, 21 Nov 2025 14:06:48 +0100 Message-ID: <20251121130234.904223470@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251121130230.985163914@linuxfoundation.org> References: <20251121130230.985163914@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Len Brown [ Upstream commit c97c057d357c4b39b153e9e430bbf8976e05bd4e ] On enabling HWP, preserve the reserved bits in MSR_PM_ENABLE. Also, skip writing the MSR_PM_ENABLE if HWP is already enabled. Signed-off-by: Len Brown Signed-off-by: Sasha Levin --- .../x86_energy_perf_policy/x86_energy_perf_policy.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c index c883f211dbcc9..0bda8e3ae7f77 100644 --- a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c +++ b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c @@ -1166,13 +1166,18 @@ int update_hwp_request_pkg(int pkg) int enable_hwp_on_cpu(int cpu) { - unsigned long long msr; + unsigned long long old_msr, new_msr; + + get_msr(cpu, MSR_PM_ENABLE, &old_msr); + + if (old_msr & 1) + return 0; /* already enabled */ - get_msr(cpu, MSR_PM_ENABLE, &msr); - put_msr(cpu, MSR_PM_ENABLE, 1); + new_msr = old_msr | 1; + put_msr(cpu, MSR_PM_ENABLE, new_msr); if (verbose) - printf("cpu%d: MSR_PM_ENABLE old: %d new: %d\n", cpu, (unsigned int) msr, 1); + printf("cpu%d: MSR_PM_ENABLE old: %llX new: %llX\n", cpu, old_msr, new_msr); return 0; } -- 2.51.0