All of lore.kernel.org
 help / color / mirror / Atom feed
From: Navaneeth K <knavaneeth786@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Navaneeth K <knavaneeth786@gmail.com>
Subject: [PATCH 3/5] staging: rtl8723bs: use standard offsetof in cfg80211 operations
Date: Sat, 22 Nov 2025 17:45:53 +0000	[thread overview]
Message-ID: <20251122174555.215109-4-knavaneeth786@gmail.com> (raw)
In-Reply-To: <20251122174555.215109-1-knavaneeth786@gmail.com>

Replace usage of the custom FIELD_OFFSET macro with the standard
offsetof() macro in ioctl_cfg80211.c.

This resolves coding style issues and standardizes
memory offset calculations.

Signed-off-by: Navaneeth K <knavaneeth786@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index 315bab373729..784c9ebf6f9c 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
@@ -1712,7 +1712,8 @@ static int cfg80211_rtw_connect(struct wiphy *wiphy, struct net_device *ndev,
 
 		if (wep_key_len > 0) {
 			wep_key_len = wep_key_len <= 5 ? 5 : 13;
-			wep_total_len = wep_key_len + FIELD_OFFSET(struct ndis_802_11_wep, key_material);
+			wep_total_len = wep_key_len +
+					offsetof(struct ndis_802_11_wep, key_material);
 			pwep = rtw_malloc(wep_total_len);
 			if (!pwep) {
 				ret = -ENOMEM;
-- 
2.43.0


  parent reply	other threads:[~2025-11-22 17:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-22 17:45 [PATCH 0/5] staging: rtl8723bs: remove custom FIELD_OFFSET macro and dead code Navaneeth K
2025-11-22 17:45 ` [PATCH 1/5] staging: rtl8723bs: remove custom FIELD_OFFSET macro Navaneeth K
2025-11-22 17:45 ` [PATCH 2/5] staging: rtl8723bs: replace FIELD_OFFSET usage with offsetof Navaneeth K
2025-11-24  8:08   ` Dan Carpenter
2025-11-24  9:17     ` david laight
2025-11-24  9:45       ` Dan Carpenter
2025-11-24 12:13         ` david laight
2025-11-24 13:07           ` Navaneeth K
2025-11-22 17:45 ` Navaneeth K [this message]
2025-11-22 17:45 ` [PATCH 4/5] staging: rtl8723bs: remove dead code from odm.c Navaneeth K
2025-11-24  8:11   ` Dan Carpenter
2025-11-22 17:45 ` [PATCH 5/5] staging: rtl8723bs: use offsetof in rtw_mlme_ext.c Navaneeth K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251122174555.215109-4-knavaneeth786@gmail.com \
    --to=knavaneeth786@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.