From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BBCDF513; Sat, 22 Nov 2025 18:17:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763835440; cv=none; b=nXQKbHCV+iWFyvplalAscQpKkD3Euwp+9wNjmWddqMSRokuSl6zWWDuq7Y5YxSjrEub/TEB/H9teXr/D9f92e/+5exCL8guN1oE4bPQXNHVOByIFLyW+CwmQ5lq8lcQpzZZZSx8jSUCqIeRZSXZXxDvMLsbD3LQbjGrKUaziKJg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763835440; c=relaxed/simple; bh=we92XnUPL2GqTAE+Ck+cg8BMRawK5MC/LOnXeHskfuE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YZ9nJNpL4I/7xpF2dKphhD2aDd1JU3WnIeMfBqBJZNjGITdsLWCihMgPo5YhkNYvzzwOPpWG0pqa378k3dsVxzq/y40+g1dgp3hPcdMqdAfp9GhmG08aq4l8hiIgkELb+nzdwVjRMKunbsOt3eIxFH2Xki8NKpyxY1aGWZXfOKs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qWp7qBzg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qWp7qBzg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42B7EC4CEF5; Sat, 22 Nov 2025 18:17:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763835439; bh=we92XnUPL2GqTAE+Ck+cg8BMRawK5MC/LOnXeHskfuE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qWp7qBzgegMBBvpNUpmYHt1dSh1dwb7l1gVTIWRYlM8OTWUUWdH975ieJ/TI6cuVG OX7gdRw1zpMWaRAmRv0Pz5kTcOJ5IekC3ZeBx9szPIC3Dql/L0kmwVZ5VGp+oau6xF K+hU9omr4xma5Czu40WtwkdKJGRRqNJhRTmnradNl8hyDB2KWgpOd/2rjf7bk2qc+q WWaus1hdoFJCoreampp5V9lRtGeRWqONH5+HwEkBZ+Hp9kkUdcQG/mGDp0/fg6NZL7 cbRX2Xcy/CEsx0PZZhycSzUq9SYMtwWCgvZRmqdsvJ9TD/UyPFWLyRIO1QANBTu2TY e1RjCaTvPOX5A== Date: Sat, 22 Nov 2025 10:17:17 -0800 From: Eric Biggers To: Christoph Hellwig Cc: "Theodore Y. Ts'o" , Jaegeuk Kim , Andreas Dilger , Chao Yu , Christian Brauner , "Darrick J. Wong" , linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 04/11] fscrypt: pass a byte offset to fscrypt_mergeable_bio Message-ID: <20251122181717.GA1626@quark> References: <20251118062159.2358085-1-hch@lst.de> <20251118062159.2358085-5-hch@lst.de> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251118062159.2358085-5-hch@lst.de> On Tue, Nov 18, 2025 at 07:21:47AM +0100, Christoph Hellwig wrote: > diff --git a/fs/crypto/inline_crypt.c b/fs/crypto/inline_crypt.c > index 1773dd7ea7cf..aba830e0827d 100644 > --- a/fs/crypto/inline_crypt.c > +++ b/fs/crypto/inline_crypt.c > @@ -361,7 +361,7 @@ EXPORT_SYMBOL_GPL(fscrypt_set_bio_crypt_ctx_bh); > * fscrypt_mergeable_bio() - test whether data can be added to a bio > * @bio: the bio being built up > * @inode: the inode for the next part of the I/O > - * @next_lblk: the next file logical block number in the I/O > + * @pos: the next file logical offset (in bytes) in the I/O In comments, maybe call it a "file position" instead of "file logical offset" to match the variable name? - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 417B7CFC522 for ; Sat, 22 Nov 2025 18:17:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nfUS4yuRrQH3Ag3A61KcKNMvqpl2KNNHkLpchml47NU=; b=DyGAd7BIpfIN+sM/c2dbq0CBVe i3Bxb8pZ7hZmate3UrCLVJPqOPX53SroCPY5xjgXrLswhfaniZestKBKjVpJzx9xECDX4ciwsYfiP j6JxkRICG6kHFG7LtoFnJ4ppum1uYRZ92ircRFqMEzvPDCkikH/jsXilU/J37g/xAkNU=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vMsAv-0001Jv-3p; Sat, 22 Nov 2025 18:17:33 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vMsAt-0001Jn-96 for linux-f2fs-devel@lists.sourceforge.net; Sat, 22 Nov 2025 18:17:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rVOiQy0R3ITXCme9nsaOPvaHsROuC5V0UxNCWO0CAbc=; b=VtCMbyLhowEzn33mBhJOhK1ous FJedlXQwmyFGqeBI7S25/nLxOKwUN+G0vy+oCcdlSLGMqhC8JyakzcwU7uoi4jBxAX9lEDVKEuXS5 xfJK5j4kEqF86IxTdtRngl5LkUAnIzgIzqAemz1xWs68JVjfPE5xv1Dsh28o4hNCcPII=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=rVOiQy0R3ITXCme9nsaOPvaHsROuC5V0UxNCWO0CAbc=; b=UzzKxHO2sfZ4GTsAMQ1nGwAdNs 7QktXd99kSnddkSWvLCsOD00kN5tTuDL1wGmfdOfrHrIpIadwBnsDjb2fGVpo3FB0VPe99CFAc7Vx Y/kS4mY+blzo+e9SyIK6qXZNcYnUlj0Jc33RUZ2bQB7s7MhwJ5aO9ewdOiCp1VAIE25w=; Received: from tor.source.kernel.org ([172.105.4.254]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vMsAs-0002C8-Sy for linux-f2fs-devel@lists.sourceforge.net; Sat, 22 Nov 2025 18:17:31 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 171C36013B; Sat, 22 Nov 2025 18:17:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42B7EC4CEF5; Sat, 22 Nov 2025 18:17:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763835439; bh=we92XnUPL2GqTAE+Ck+cg8BMRawK5MC/LOnXeHskfuE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qWp7qBzgegMBBvpNUpmYHt1dSh1dwb7l1gVTIWRYlM8OTWUUWdH975ieJ/TI6cuVG OX7gdRw1zpMWaRAmRv0Pz5kTcOJ5IekC3ZeBx9szPIC3Dql/L0kmwVZ5VGp+oau6xF K+hU9omr4xma5Czu40WtwkdKJGRRqNJhRTmnradNl8hyDB2KWgpOd/2rjf7bk2qc+q WWaus1hdoFJCoreampp5V9lRtGeRWqONH5+HwEkBZ+Hp9kkUdcQG/mGDp0/fg6NZL7 cbRX2Xcy/CEsx0PZZhycSzUq9SYMtwWCgvZRmqdsvJ9TD/UyPFWLyRIO1QANBTu2TY e1RjCaTvPOX5A== Date: Sat, 22 Nov 2025 10:17:17 -0800 To: Christoph Hellwig Message-ID: <20251122181717.GA1626@quark> References: <20251118062159.2358085-1-hch@lst.de> <20251118062159.2358085-5-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20251118062159.2358085-5-hch@lst.de> X-Headers-End: 1vMsAs-0002C8-Sy Subject: Re: [f2fs-dev] [PATCH 04/11] fscrypt: pass a byte offset to fscrypt_mergeable_bio X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eric Biggers via Linux-f2fs-devel Reply-To: Eric Biggers Cc: Christian Brauner , "Theodore Y. Ts'o" , "Darrick J. Wong" , linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, Andreas Dilger , linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-ext4@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Tue, Nov 18, 2025 at 07:21:47AM +0100, Christoph Hellwig wrote: > diff --git a/fs/crypto/inline_crypt.c b/fs/crypto/inline_crypt.c > index 1773dd7ea7cf..aba830e0827d 100644 > --- a/fs/crypto/inline_crypt.c > +++ b/fs/crypto/inline_crypt.c > @@ -361,7 +361,7 @@ EXPORT_SYMBOL_GPL(fscrypt_set_bio_crypt_ctx_bh); > * fscrypt_mergeable_bio() - test whether data can be added to a bio > * @bio: the bio being built up > * @inode: the inode for the next part of the I/O > - * @next_lblk: the next file logical block number in the I/O > + * @pos: the next file logical offset (in bytes) in the I/O In comments, maybe call it a "file position" instead of "file logical offset" to match the variable name? - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel