From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 405462D5C67; Mon, 24 Nov 2025 06:30:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763965817; cv=none; b=YCAS+61xzpspYd6K20tXgXuTLghmiS49m4YNR7J8NG6UbHG57nt6bi5exe27EJA9Gj5AWN70rvWGPYyqo0Gn+/cRaA6k/SJuYX6zt0YR3ZBbWFJ5rkOpW8l7p1wVnpdUPutriDRO/9Cbhbnqef7aPkpq4JmGQP0LPEJ67huzsZU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763965817; c=relaxed/simple; bh=WIVG4JvopaUAhb6ikTuILxILFdoaTMcY/q5G1Hl4Ync=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YeHO1aJ5OjHi5bW/Kk8AO9I0tgr0e3/3Y4VkCdKWMQmGT8sqSAoraBGrXtawZM6zSLf3mIrSU+pPBpe5FIEgUCyEd5l7e0Uo2tC8VOY1GtahPue0jVCZUYVQiEl16vs0Rr+bXxSy5gOsJslklHvyh05NY1Xxbwds+SJjt/Xfl0Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id B44AD68B05; Mon, 24 Nov 2025 07:30:11 +0100 (CET) Date: Mon, 24 Nov 2025 07:30:11 +0100 From: Christoph Hellwig To: Chaitanya Kulkarni Cc: axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org, mpatocka@redhat.com, song@kernel.org, yukuai@fnnas.com, hch@lst.de, sagi@grimberg.me, kch@nvidia.com, jaegeuk@kernel.org, chao@kernel.org, cem@kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@lists.linux.dev, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH V2 4/5] f2fs: ignore discard return value Message-ID: <20251124063011.GA16808@lst.de> References: <20251124025737.203571-1-ckulkarnilinux@gmail.com> <20251124025737.203571-5-ckulkarnilinux@gmail.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251124025737.203571-5-ckulkarnilinux@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Sun, Nov 23, 2025 at 06:57:36PM -0800, Chaitanya Kulkarni wrote: > + __blkdev_issue_discard(bdev, > + SECTOR_FROM_BLOCK(start), > + SECTOR_FROM_BLOCK(len), > + GFP_NOFS, &bio); This can be shortened a bit as well: __blkdev_issue_discard(bdev, SECTOR_FROM_BLOCK(start), SECTOR_FROM_BLOCK(len), GFP_NOFS, &bio); Otherwise looks good: Reviewed-by: Christoph Hellwig From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3738CFA466 for ; Mon, 24 Nov 2025 06:30:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TnhI37av0wxROuzWPn2VUKyIQ1PlD5usZS4qwkaFbds=; b=XiicX98nZIDCNtDRu8nr0XymSM QYfEQMBqBqAfOTJbwufdpY0KkFuIect0NnDIVVC9b0pkFSvakZhQaS6ec1VexAlY0a8mjVTftBKYL hNVROP8xLdW8h+2DNv1+stvEpDKXzhhvZ/yifGNWB3V1mWpInyb7jA2si7Jp8h33xUmg=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vNQ5v-0006ww-9i; Mon, 24 Nov 2025 06:30:39 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vNQ5h-0006wf-SM for linux-f2fs-devel@lists.sourceforge.net; Mon, 24 Nov 2025 06:30:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Q35Uzhw2kUdUnX+0WJUFRb4cV3+/l9MC0GtyEz30cco=; b=PB1JEBiG25HVhw6p+IIQIqC5dx T5H/qJB3MDZCMf8VWMvQKhBBlhPTtZYgTVB52oZDAze4Gur6ZiRRqgu3Plhkq6pAdn4LjCiUhdYp0 0l1pUWv1nJfrQdmP5IM/btyf3ENB8kLNUqb2WCg4XmiZ0fSpZGimJ2lgfP1mOQhhjbgY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Q35Uzhw2kUdUnX+0WJUFRb4cV3+/l9MC0GtyEz30cco=; b=DqdEm1pUdV4IO4VNH0rCo5LpCH /tvnPlsopaIV0Wf+i7qynBtAjoyR50X/ig6ipy8krELQMeu5YQ/dFBTnf9z7CoXZJKPzBkiA0tXvI 8QVyVxJKU9cxYc4nohoemhg6r0zNqNj4ff7DdiXKkfp1eKTYibplgMt0GHTxGZlNXpoM=; Received: from verein.lst.de ([213.95.11.211]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vNQ5h-0007EM-6m for linux-f2fs-devel@lists.sourceforge.net; Mon, 24 Nov 2025 06:30:25 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id B44AD68B05; Mon, 24 Nov 2025 07:30:11 +0100 (CET) Date: Mon, 24 Nov 2025 07:30:11 +0100 From: Christoph Hellwig To: Chaitanya Kulkarni Message-ID: <20251124063011.GA16808@lst.de> References: <20251124025737.203571-1-ckulkarnilinux@gmail.com> <20251124025737.203571-5-ckulkarnilinux@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20251124025737.203571-5-ckulkarnilinux@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Headers-End: 1vNQ5h-0007EM-6m Subject: Re: [f2fs-dev] [PATCH V2 4/5] f2fs: ignore discard return value X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, dm-devel@lists.linux.dev, linux-f2fs-devel@lists.sourceforge.net, kch@nvidia.com, sagi@grimberg.me, linux-xfs@vger.kernel.org, cem@kernel.org, snitzer@kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-raid@vger.kernel.org, linux-block@vger.kernel.org, song@kernel.org, mpatocka@redhat.com, jaegeuk@kernel.org, bpf@vger.kernel.org, yukuai@fnnas.com, hch@lst.de, agk@redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Sun, Nov 23, 2025 at 06:57:36PM -0800, Chaitanya Kulkarni wrote: > + __blkdev_issue_discard(bdev, > + SECTOR_FROM_BLOCK(start), > + SECTOR_FROM_BLOCK(len), > + GFP_NOFS, &bio); This can be shortened a bit as well: __blkdev_issue_discard(bdev, SECTOR_FROM_BLOCK(start), SECTOR_FROM_BLOCK(len), GFP_NOFS, &bio); Otherwise looks good: Reviewed-by: Christoph Hellwig _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel