All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Kuniyuki Iwashima <kuniyu@google.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: [TEST] so_peek_off flakes on new NIPA systems
Date: Mon, 24 Nov 2025 07:07:22 -0800	[thread overview]
Message-ID: <20251124070722.1e828c53@kernel.org> (raw)

Hi Kuniyuki!

We upgraded our system for NIPA recently to netdev foundation one 
(as you know). Looks like net/af_unix: so_peek_off is flaking
on both debug and non-debug builds quite a lot with:

# # so_peek_off.c:149:two_chunks_overlap_blocking:Expected -1 (-1) != bytes (-1)
# # two_chunks_overlap_blocking: Test terminated by assertion
# #          FAIL  so_peek_off.stream.two_chunks_overlap_blocking

https://netdev-ctrl.bots.linux.dev/logs/vmksft/net-dbg/results/399761/134-so-peek-off/stdout

The newer system is 10-20% faster it's also moved from AWS Linux to
Fedora. But I suspect the real reason is that our old system had
quietly broken compilation of af_unix selftests
because of Wflex-array-member-not-at-end which AWS Linux gcc doesn't
understand:

gcc: error: unrecognized command-line option ‘-Wflex-array-member-not-at-end’
make: *** [../../lib.mk:222: /home/virtme/testing/wt-1/tools/testing/selftests/net/af_unix/diag_uid] Error 1

So effectively we're been running some old copy of af_unix tests since
this flag was added.

             reply	other threads:[~2025-11-24 15:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-24 15:07 Jakub Kicinski [this message]
2025-11-24 19:04 ` [TEST] so_peek_off flakes on new NIPA systems Kuniyuki Iwashima
2025-11-24 19:53   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251124070722.1e828c53@kernel.org \
    --to=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.