All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herve Codina <herve.codina@bootlin.com>
To: Haotian Zhang <vulab@iscas.ac.cn>
Cc: gregkh@linuxfoundation.org, linux-renesas-soc@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: renesas_usbf: Handle devm_pm_runtime_enable() errors
Date: Mon, 24 Nov 2025 08:43:58 +0100	[thread overview]
Message-ID: <20251124084358.06492237@bootlin.com> (raw)
In-Reply-To: <20251124022215.1619-1-vulab@iscas.ac.cn>

Hi Haotian,

On Mon, 24 Nov 2025 10:22:15 +0800
Haotian Zhang <vulab@iscas.ac.cn> wrote:

> devm_pm_runtime_enable() can fail due to memory allocation.
> The current code ignores its return value, potentially causing
> pm_runtime_resume_and_get() to operate on uninitialized runtime
> PM state.
> 
> Check the return value of devm_pm_runtime_enable() and return on failure.
> 
> Fixes: 3e6e14ffdea4 ("usb: gadget: udc: add Renesas RZ/N1 USBF controller support")
> Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>

Thanks for the patch.

Acked-by: Herve Codina <herve.codina@bootlin.com>

Best regards,
Hervé

  reply	other threads:[~2025-11-24  7:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-24  2:22 [PATCH] usb: gadget: renesas_usbf: Handle devm_pm_runtime_enable() errors Haotian Zhang
2025-11-24  7:43 ` Herve Codina [this message]
2025-11-24 13:15 ` Geert Uytterhoeven
2025-11-26 12:47   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251124084358.06492237@bootlin.com \
    --to=herve.codina@bootlin.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=vulab@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.