From: Christoph Hellwig <hch@lst.de>
To: Uladzislau Rezki <urezki@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
Mikulas Patocka <mpatocka@redhat.com>,
Benjamin Marzinski <bmarzins@redhat.com>,
Alasdair Kergon <agk@redhat.com>, DMML <dm-devel@lists.linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Snitzer <snitzer@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH] dm-ebs: Mark full buffer dirty even on partial write
Date: Mon, 24 Nov 2025 15:30:44 +0100 [thread overview]
Message-ID: <20251124143044.GA17164@lst.de> (raw)
In-Reply-To: <aSBnXqX9jmoKuv4Y@pc636>
On Fri, Nov 21, 2025 at 02:21:34PM +0100, Uladzislau Rezki wrote:
> - offset &= -DM_BUFIO_WRITE_ALIGN;
> - end += DM_BUFIO_WRITE_ALIGN - 1;
> - end &= -DM_BUFIO_WRITE_ALIGN;
> + align = max(DM_BUFIO_WRITE_ALIGN, bdev_logical_block_size(b->c->bdev));
> + offset &= -align;
> + end += align - 1;
> + end &= -align;
> if (unlikely(end > b->c->block_size))
> end = b->c->block_size;
> <snip>
>
> and it fixes the setup which i described in the commit message, but i
> have question.
And this patch, using bdev_logical_block_size looks correct.
>
> Why in dm-ebs we need to offload partial buffer < ubf size?
I don't understand this question. What is ubf? What does partial
buffer mean in this context, and what does offload mean?
next prev parent reply other threads:[~2025-11-24 14:30 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 10:59 [RESEND PATCH] dm-ebs: Mark full buffer dirty even on partial write Uladzislau Rezki (Sony)
2025-11-17 20:48 ` Mikulas Patocka
2025-11-18 11:39 ` Uladzislau Rezki
2025-11-18 12:00 ` Mikulas Patocka
2025-11-18 12:40 ` Uladzislau Rezki
2025-11-18 12:46 ` Christoph Hellwig
2025-11-18 14:15 ` Benjamin Marzinski
2025-11-18 17:21 ` Mikulas Patocka
2025-11-19 5:46 ` Christoph Hellwig
2025-11-19 8:43 ` Uladzislau Rezki
2025-11-19 8:53 ` Christoph Hellwig
2025-11-19 8:57 ` Uladzislau Rezki
2025-11-19 9:00 ` Christoph Hellwig
2025-11-19 9:01 ` Uladzislau Rezki
2025-11-19 9:05 ` Christoph Hellwig
2025-11-19 9:13 ` Uladzislau Rezki
2025-11-19 9:17 ` Christoph Hellwig
2025-11-19 17:26 ` Mikulas Patocka
2025-11-20 6:21 ` Christoph Hellwig
2025-11-20 12:08 ` Uladzislau Rezki
2025-11-20 12:40 ` Uladzislau Rezki
2025-11-21 7:25 ` Christoph Hellwig
2025-11-21 7:24 ` Christoph Hellwig
2025-11-21 13:21 ` Uladzislau Rezki
2025-11-21 16:48 ` Benjamin Marzinski
2025-11-24 10:43 ` Uladzislau Rezki
2025-11-24 14:30 ` Christoph Hellwig [this message]
2025-11-24 15:30 ` Uladzislau Rezki
2025-11-24 17:00 ` Christoph Hellwig
2025-11-24 18:05 ` Uladzislau Rezki
-- strict thread matches above, loose matches on Subject: below --
2025-10-14 14:47 Uladzislau Rezki (Sony)
2025-10-16 19:59 ` Andrew Morton
2025-10-17 15:55 ` Uladzislau Rezki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251124143044.GA17164@lst.de \
--to=hch@lst.de \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bmarzins@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@redhat.com \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.