From: Jakub Kicinski <kuba@kernel.org>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
jiri@resnulli.us, xiyou.wangcong@gmail.com,
netdev@vger.kernel.org, dcaratti@redhat.com
Subject: Re: [PATCH net-next 1/2] net/sched: act_mirred: Fix infinite loop
Date: Mon, 24 Nov 2025 14:51:15 -0800 [thread overview]
Message-ID: <20251124145115.30c01882@kernel.org> (raw)
In-Reply-To: <20251124200825.241037-1-jhs@mojatatu.com>
On Mon, 24 Nov 2025 15:08:24 -0500 Jamal Hadi Salim wrote:
> When doing multiport mirroring we dont detect infinite loops.
>
> Example (see the first accompanying tdc test):
> packet showing up on port0 ingress mirred redirect --> port1 egress
> packet showing up on port1 egress mirred redirect --> port0 ingress
>
> Example 2 (see the second accompanying tdc test)
> port0 egress --> port1 ingress --> port0 egress
>
> Fix this by remembering the source dev where mirred ran as opposed to
> destination/target dev
>
> Fixes: fe946a751d9b ("net/sched: act_mirred: add loop detection")
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
Hm, this breaks net/fib_tests.sh:
# 23.80 [+0.00] IPv4 rp_filter tests
# 25.63 [+1.84] TEST: rp_filter passes local packets [FAIL]
# 26.65 [+1.02] TEST: rp_filter passes loopback packets [FAIL]
https://netdev-3.bots.linux.dev/vmksft-net/results/400301/10-fib-tests-sh/stdout
Not making a statement on whether the fix itself is acceptable
but if it is we gotta fix that test too..
--
pw-bot: cr
next prev parent reply other threads:[~2025-11-24 22:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 20:08 [PATCH net-next 1/2] net/sched: act_mirred: Fix infinite loop Jamal Hadi Salim
2025-11-24 20:08 ` [PATCH net-next 2/2] selftests/tc-testing: Add test cases exercising mirred redirects (with loops) Jamal Hadi Salim
2025-11-24 22:51 ` Jakub Kicinski [this message]
2025-11-25 16:20 ` [PATCH net-next 1/2] net/sched: act_mirred: Fix infinite loop Jamal Hadi Salim
2025-11-26 16:26 ` Jamal Hadi Salim
2025-11-26 16:40 ` Eric Dumazet
2025-11-26 18:14 ` Jamal Hadi Salim
2025-11-26 18:19 ` Eric Dumazet
2025-11-26 19:00 ` Jamal Hadi Salim
2025-11-26 20:20 ` Jamal Hadi Salim
2025-11-26 20:29 ` Eric Dumazet
2025-11-27 14:45 ` Jamal Hadi Salim
2025-11-27 15:11 ` Eric Dumazet
2025-11-27 15:23 ` Jamal Hadi Salim
2025-11-27 16:21 ` Jamal Hadi Salim
2025-12-03 14:27 ` Jamal Hadi Salim
2025-12-10 14:59 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251124145115.30c01882@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.