From: Tony Luck <tony.luck@intel.com>
To: Fenghua Yu <fenghuay@nvidia.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
Peter Newman <peternewman@google.com>,
James Morse <james.morse@arm.com>,
Babu Moger <babu.moger@amd.com>,
Drew Fustini <dfustini@baylibre.com>,
Dave Martin <Dave.Martin@arm.com>, Chen Yu <yu.c.chen@intel.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
patches@lists.linux.dev, Tony Luck <tony.luck@intel.com>
Subject: [PATCH v14 03/32] x86/resctrl: Refactor domain_remove_cpu_mon() ready for new domain types
Date: Mon, 24 Nov 2025 10:53:40 -0800 [thread overview]
Message-ID: <20251124185412.24155-4-tony.luck@intel.com> (raw)
In-Reply-To: <20251124185412.24155-1-tony.luck@intel.com>
New telemetry events will be associated with a new package scoped resource with
new domain structures.
Refactor domain_remove_cpu_mon() so all the L3 domain processing is separate
from general domain actions of clearing the CPU bit in the mask.
Signed-off-by: Tony Luck <tony.luck@intel.com>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
---
arch/x86/kernel/cpu/resctrl/core.c | 27 +++++++++++++++++----------
1 file changed, 17 insertions(+), 10 deletions(-)
diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
index 2a568b316711..49b133e847d4 100644
--- a/arch/x86/kernel/cpu/resctrl/core.c
+++ b/arch/x86/kernel/cpu/resctrl/core.c
@@ -631,9 +631,7 @@ static void domain_remove_cpu_ctrl(int cpu, struct rdt_resource *r)
static void domain_remove_cpu_mon(int cpu, struct rdt_resource *r)
{
int id = get_domain_id_from_scope(cpu, r->mon_scope);
- struct rdt_hw_mon_domain *hw_dom;
struct rdt_domain_hdr *hdr;
- struct rdt_mon_domain *d;
lockdep_assert_held(&domain_list_lock);
@@ -650,20 +648,29 @@ static void domain_remove_cpu_mon(int cpu, struct rdt_resource *r)
return;
}
- if (!domain_header_is_valid(hdr, RESCTRL_MON_DOMAIN, r->rid))
+ cpumask_clear_cpu(cpu, &hdr->cpu_mask);
+ if (!cpumask_empty(&hdr->cpu_mask))
return;
- d = container_of(hdr, struct rdt_mon_domain, hdr);
- hw_dom = resctrl_to_arch_mon_dom(d);
+ switch (r->rid) {
+ case RDT_RESOURCE_L3: {
+ struct rdt_hw_mon_domain *hw_dom;
+ struct rdt_mon_domain *d;
- cpumask_clear_cpu(cpu, &d->hdr.cpu_mask);
- if (cpumask_empty(&d->hdr.cpu_mask)) {
+ if (!domain_header_is_valid(hdr, RESCTRL_MON_DOMAIN, RDT_RESOURCE_L3))
+ return;
+
+ d = container_of(hdr, struct rdt_mon_domain, hdr);
+ hw_dom = resctrl_to_arch_mon_dom(d);
resctrl_offline_mon_domain(r, d);
- list_del_rcu(&d->hdr.list);
+ list_del_rcu(&hdr->list);
synchronize_rcu();
mon_domain_free(hw_dom);
-
- return;
+ break;
+ }
+ default:
+ pr_warn_once("Unknown resource rid=%d\n", r->rid);
+ break;
}
}
--
2.51.1
next prev parent reply other threads:[~2025-11-24 18:54 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 18:53 [PATCH v14 00/32] x86,fs/resctrl telemetry monitoring Tony Luck
2025-11-24 18:53 ` [PATCH v14 01/32] x86,fs/resctrl: Improve domain type checking Tony Luck
2025-11-24 18:53 ` [PATCH v14 02/32] x86/resctrl: Move L3 initialization into new helper function Tony Luck
2025-11-24 18:53 ` Tony Luck [this message]
2025-12-02 16:01 ` [PATCH v14 03/32] x86/resctrl: Refactor domain_remove_cpu_mon() ready for new domain types Reinette Chatre
2025-11-24 18:53 ` [PATCH v14 04/32] x86/resctrl: Clean up domain_remove_cpu_ctrl() Tony Luck
2025-11-24 18:53 ` [PATCH v14 05/32] x86,fs/resctrl: Refactor domain create/remove using struct rdt_domain_hdr Tony Luck
2025-12-02 16:01 ` Reinette Chatre
2025-11-24 18:53 ` [PATCH v14 06/32] fs/resctrl: Split L3 dependent parts out of __mon_event_count() Tony Luck
2025-12-02 16:02 ` Reinette Chatre
2025-11-24 18:53 ` [PATCH v14 07/32] x86,fs/resctrl: Use struct rdt_domain_hdr when reading counters Tony Luck
2025-12-02 16:06 ` Reinette Chatre
2025-12-02 20:33 ` Luck, Tony
2025-12-02 22:24 ` Reinette Chatre
2025-12-02 23:22 ` Luck, Tony
2025-11-24 18:53 ` [PATCH v14 08/32] x86,fs/resctrl: Rename struct rdt_mon_domain and rdt_hw_mon_domain Tony Luck
2025-12-02 16:07 ` Reinette Chatre
2025-11-24 18:53 ` [PATCH v14 09/32] x86,fs/resctrl: Rename some L3 specific functions Tony Luck
2025-11-24 18:53 ` [PATCH v14 10/32] fs/resctrl: Make event details accessible to functions when reading events Tony Luck
2025-11-24 18:53 ` [PATCH v14 11/32] x86,fs/resctrl: Handle events that can be read from any CPU Tony Luck
2025-12-02 16:08 ` Reinette Chatre
2025-11-24 18:53 ` [PATCH v14 12/32] x86,fs/resctrl: Support binary fixed point event counters Tony Luck
2025-12-02 16:11 ` Reinette Chatre
2025-11-24 18:53 ` [PATCH v14 13/32] x86,fs/resctrl: Add an architectural hook called for each mount Tony Luck
2025-11-24 18:53 ` [PATCH v14 14/32] x86,fs/resctrl: Add and initialize rdt_resource for package scope monitor Tony Luck
2025-12-02 16:11 ` Reinette Chatre
2025-11-24 18:53 ` [PATCH v14 15/32] fs/resctrl: Emphasize that L3 monitoring resource is required for summing domains Tony Luck
2025-11-24 18:53 ` [PATCH v14 16/32] x86/resctrl: Discover hardware telemetry events Tony Luck
2025-12-02 16:18 ` Reinette Chatre
2025-11-24 18:53 ` [PATCH v14 17/32] x86,fs/resctrl: Fill in details of events for guid 0x26696143 and 0x26557651 Tony Luck
2025-12-02 16:19 ` Reinette Chatre
2025-11-24 18:53 ` [PATCH v14 18/32] x86,fs/resctrl: Add architectural event pointer Tony Luck
2025-11-24 18:53 ` [PATCH v14 19/32] x86/resctrl: Find and enable usable telemetry events Tony Luck
2025-12-02 16:21 ` Reinette Chatre
2025-11-24 18:53 ` [PATCH v14 20/32] x86/resctrl: Read " Tony Luck
2025-12-02 16:21 ` Reinette Chatre
2025-11-24 18:53 ` [PATCH v14 21/32] fs/resctrl: Refactor mkdir_mondata_subdir() Tony Luck
2025-11-24 18:53 ` [PATCH v14 22/32] fs/resctrl: Refactor rmdir_mondata_subdir_allrdtgrp() Tony Luck
2025-11-24 18:54 ` [PATCH v14 23/32] x86,fs/resctrl: Handle domain creation/deletion for RDT_RESOURCE_PERF_PKG Tony Luck
2025-11-24 18:54 ` [PATCH v14 24/32] x86/resctrl: Add energy/perf choices to rdt boot option Tony Luck
2025-12-02 16:28 ` Reinette Chatre
2025-12-03 18:04 ` Luck, Tony
2025-12-03 21:21 ` Reinette Chatre
2025-12-03 22:27 ` Luck, Tony
2025-12-03 23:25 ` Reinette Chatre
2025-11-24 18:54 ` [PATCH v14 25/32] x86/resctrl: Handle number of RMIDs supported by RDT_RESOURCE_PERF_PKG Tony Luck
2025-12-02 16:31 ` Reinette Chatre
2025-11-24 18:54 ` [PATCH v14 26/32] fs/resctrl: Move allocation/free of closid_num_dirty_rmid[] Tony Luck
2025-11-24 18:54 ` [PATCH v14 27/32] x86,fs/resctrl: Compute number of RMIDs as minimum across resources Tony Luck
2025-11-24 18:54 ` [PATCH v14 28/32] fs/resctrl: Move RMID initialization to first mount Tony Luck
2025-11-24 18:54 ` [PATCH v14 29/32] x86/resctrl: Enable RDT_RESOURCE_PERF_PKG Tony Luck
2025-11-24 18:54 ` [PATCH v14 30/32] fs/resctrl: Provide interface to create architecture specific debugfs area Tony Luck
2025-11-24 18:54 ` [PATCH v14 31/32] x86/resctrl: Add debugfs files to show telemetry aggregator status Tony Luck
2025-11-24 18:54 ` [PATCH v14 32/32] x86,fs/resctrl: Update documentation for telemetry events Tony Luck
2025-12-02 16:34 ` Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251124185412.24155-4-tony.luck@intel.com \
--to=tony.luck@intel.com \
--cc=Dave.Martin@arm.com \
--cc=babu.moger@amd.com \
--cc=dfustini@baylibre.com \
--cc=fenghuay@nvidia.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=patches@lists.linux.dev \
--cc=peternewman@google.com \
--cc=reinette.chatre@intel.com \
--cc=x86@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.