From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@lst.de>,
brauner@kernel.org, djwong@kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
syzbot+a2b9a4ed0d61b1efb3f5@syzkaller.appspotmail.com
Subject: Re: [PATCH] iomap: allocate s_dio_done_wq for async reads as well
Date: Tue, 25 Nov 2025 07:35:06 +0100 [thread overview]
Message-ID: <20251125063506.GA14851@lst.de> (raw)
In-Reply-To: <aSTR3GHyAZKdRCqo@dread.disaster.area>
On Tue, Nov 25, 2025 at 08:45:00AM +1100, Dave Chinner wrote:
> But I can't help but wonder about putting this in the fast path....
>
> i.e. on the first io_uring/AIO DIO read or write, we will need
> allocate this work queue. I think that's getting quite common in
> applications and utilities these days, so filesystems are
> increasingly likely to need this wq.
>
> Maybe we should make this wq init unconditional and move it to fs
> superblock initialisation? That would remove this "only needed once
> for init" check that is made on every call through the the IO fast
> path....
I agree, and I originally did that, and it caused a long bikeshed.
So not feeling like reopening that can of worms right now even if I
agree with the sentiment.
next prev parent reply other threads:[~2025-11-25 6:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 14:00 [PATCH] iomap: allocate s_dio_done_wq for async reads as well Christoph Hellwig
2025-11-24 16:32 ` Darrick J. Wong
2025-11-24 21:45 ` Dave Chinner
2025-11-25 6:35 ` Christoph Hellwig [this message]
2025-11-25 8:23 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251125063506.GA14851@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=syzbot+a2b9a4ed0d61b1efb3f5@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.