diff for duplicates of <202511252118.PY7eERkg-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 7fb1a01..fe98701 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,19 +1,13 @@ -BCC: lkp@intel.com -CC: oe-kbuild-all@lists.linux.dev -TO: Kent Overstreet <kent.overstreet@linux.dev> - tree: https://github.com/koverstreet/bcachefs master head: 09be9a5a514734ebdd6fd840964815b2b0823c66 commit: 312c51e00acfd6ab012061bbb080ff0b524d7b29 [986/990] bcachefs: read_extent_rbio_alloc() -:::::: branch date: 10 hours ago -:::::: commit date: 12 hours ago config: riscv-randconfig-r072-20251125 (https://download.01.org/0day-ci/archive/20251125/202511252118.PY7eERkg-lkp@intel.com/config) compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9e9fe08b16ea2c4d9867fb4974edf2a3776d6ece) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> -| Reported-by: Dan Carpenter <error27@gmail.com> +| Reported-by: Dan Carpenter <dan.carpenter@linaro.org> | Closes: https://lore.kernel.org/r/202511252118.PY7eERkg-lkp@intel.com/ smatch warnings: @@ -21,7 +15,6 @@ fs/bcachefs/data/read.c:1327 __bch2_read_extent() error: we previously assumed ' vim +/ca +1327 fs/bcachefs/data/read.c -312c51e00acfd6 fs/bcachefs/data/read.c Kent Overstreet 2025-11-24 1165 312c51e00acfd6 fs/bcachefs/data/read.c Kent Overstreet 2025-11-24 1166 int __bch2_read_extent(struct btree_trans *trans, 312c51e00acfd6 fs/bcachefs/data/read.c Kent Overstreet 2025-11-24 1167 struct bch_read_bio *orig, 1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1168 struct bvec_iter iter, struct bpos read_pos, @@ -164,6 +157,9 @@ dff6de9518848b fs/bcachefs/io_read.c Kent Overstreet 2024-12-30 1297 } 1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1305 * hit: 1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1306 */ 3fb8bacb14b6fb fs/bcachefs/io_read.c Kent Overstreet 2025-03-12 @1307 if (ca && pick.ptr.cached && !u) + ^^ +There are a number of places which assume "ca" can be NULL + 1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1308 bch2_bucket_io_time_reset(trans, pick.ptr.dev, 1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1309 PTR_BUCKET_NR(ca, &pick.ptr), READ); 1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1310 @@ -184,8 +180,13 @@ a87e7d26cb7538 fs/bcachefs/data/read.c Kent Overstreet 2025-11-24 1323 bch2 1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1325 } 1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1326 1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 @1327 this_cpu_add(ca->io_done->sectors[READ][BCH_DATA_user], + ^^^^ + 1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1328 bio_sectors(&rbio->bio)); 1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1329 bio_set_dev(&rbio->bio, ca->disk_sb.bdev); + ^^^^^^^^^^^ +Unchecked dereferences. + 1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1330 1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1331 if (unlikely(c->opts.no_data_io)) { 9157b3ddfb151d fs/bcachefs/io_read.c Kent Overstreet 2025-01-17 1332 if (likely(!(flags & BCH_READ_in_retry))) @@ -261,13 +262,6 @@ de73677ff8e677 fs/bcachefs/io_read.c Kent Overstreet 2025-03-08 1401 !( 1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1402 bch2_rbio_done(orig); 1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1403 return 0; 1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1404 } -1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1405 - -:::::: The code at line 1327 was first introduced by commit -:::::: 1809b8cba756d32bd6e976ed4ee64efdf66c6d94 bcachefs: Break up io.c - -:::::: TO: Kent Overstreet <kent.overstreet@linux.dev> -:::::: CC: Kent Overstreet <kent.overstreet@linux.dev> -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index 5d683d8..0bd243f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,27 +1,22 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <dan.carpenter@linaro.org>\0" "Subject\0[koverstreet-bcachefs:master 986/990] fs/bcachefs/data/read.c:1327 __bch2_read_extent() error: we previously assumed 'ca' could be null (see line 1307)\0" - "Date\0Tue, 25 Nov 2025 21:53:10 +0800\0" - "To\0oe-kbuild@lists.linux.dev\0" + "Date\0Tue, 25 Nov 2025 16:58:00 +0300\0" + "To\0oe-kbuild@lists.linux.dev" + " Kent Overstreet <kent.overstreet@linux.dev>\0" "Cc\0lkp@intel.com" - " Dan Carpenter <error27@gmail.com>\0" + " oe-kbuild-all@lists.linux.dev\0" "\00:1\0" "b\0" - "BCC: lkp@intel.com\n" - "CC: oe-kbuild-all@lists.linux.dev\n" - "TO: Kent Overstreet <kent.overstreet@linux.dev>\n" - "\n" "tree: https://github.com/koverstreet/bcachefs master\n" "head: 09be9a5a514734ebdd6fd840964815b2b0823c66\n" "commit: 312c51e00acfd6ab012061bbb080ff0b524d7b29 [986/990] bcachefs: read_extent_rbio_alloc()\n" - ":::::: branch date: 10 hours ago\n" - ":::::: commit date: 12 hours ago\n" "config: riscv-randconfig-r072-20251125 (https://download.01.org/0day-ci/archive/20251125/202511252118.PY7eERkg-lkp@intel.com/config)\n" "compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9e9fe08b16ea2c4d9867fb4974edf2a3776d6ece)\n" "\n" "If you fix the issue in a separate patch/commit (i.e. not just a new version of\n" "the same patch/commit), kindly add following tags\n" "| Reported-by: kernel test robot <lkp@intel.com>\n" - "| Reported-by: Dan Carpenter <error27@gmail.com>\n" + "| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>\n" "| Closes: https://lore.kernel.org/r/202511252118.PY7eERkg-lkp@intel.com/\n" "\n" "smatch warnings:\n" @@ -29,7 +24,6 @@ "\n" "vim +/ca +1327 fs/bcachefs/data/read.c\n" "\n" - "312c51e00acfd6 fs/bcachefs/data/read.c Kent Overstreet 2025-11-24 1165 \n" "312c51e00acfd6 fs/bcachefs/data/read.c Kent Overstreet 2025-11-24 1166 int __bch2_read_extent(struct btree_trans *trans,\n" "312c51e00acfd6 fs/bcachefs/data/read.c Kent Overstreet 2025-11-24 1167 \t\t struct bch_read_bio *orig,\n" "1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1168 \t\t struct bvec_iter iter, struct bpos read_pos,\n" @@ -172,6 +166,9 @@ "1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1305 \t * hit:\n" "1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1306 \t */\n" "3fb8bacb14b6fb fs/bcachefs/io_read.c Kent Overstreet 2025-03-12 @1307 \tif (ca && pick.ptr.cached && !u)\n" + " ^^\n" + "There are a number of places which assume \"ca\" can be NULL\n" + "\n" "1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1308 \t\tbch2_bucket_io_time_reset(trans, pick.ptr.dev,\n" "1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1309 \t\t\tPTR_BUCKET_NR(ca, &pick.ptr), READ);\n" "1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1310 \n" @@ -192,8 +189,13 @@ "1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1325 \t\t}\n" "1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1326 \n" "1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 @1327 \t\tthis_cpu_add(ca->io_done->sectors[READ][BCH_DATA_user],\n" + " ^^^^\n" + "\n" "1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1328 \t\t\t bio_sectors(&rbio->bio));\n" "1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1329 \t\tbio_set_dev(&rbio->bio, ca->disk_sb.bdev);\n" + " ^^^^^^^^^^^\n" + "Unchecked dereferences.\n" + "\n" "1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1330 \n" "1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1331 \t\tif (unlikely(c->opts.no_data_io)) {\n" "9157b3ddfb151d fs/bcachefs/io_read.c Kent Overstreet 2025-01-17 1332 \t\t\tif (likely(!(flags & BCH_READ_in_retry)))\n" @@ -269,16 +271,9 @@ "1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1402 \t\tbch2_rbio_done(orig);\n" "1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1403 \treturn 0;\n" "1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1404 }\n" - "1809b8cba756d3 fs/bcachefs/io_read.c Kent Overstreet 2023-09-10 1405 \n" - "\n" - ":::::: The code at line 1327 was first introduced by commit\n" - ":::::: 1809b8cba756d32bd6e976ed4ee64efdf66c6d94 bcachefs: Break up io.c\n" - "\n" - ":::::: TO: Kent Overstreet <kent.overstreet@linux.dev>\n" - ":::::: CC: Kent Overstreet <kent.overstreet@linux.dev>\n" "\n" "-- \n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -cf662931efe9aac386470485b584c7d82f4eaee4503c56a261f04a94556e2014 +40b40ac3e2dd3c775e1ac2f533b5ad4ac30d578cbe9c26f3f2f4437ee76fa257
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.