All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Tso" <tytso@mit.edu>
To: Sun Yongjian <sunyongjian1@huawei.com>
Cc: Jan Kara <jack@suse.cz>,
	linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	yangerkun@huawei.com, yi.zhang@huawei.com, libaokun1@huawei.com,
	chengzhihao1@huawei.com
Subject: Re: [PATCH 2/2] ext4: improve integrity checking in __mb_check_buddy by enhancing order-0 validation
Date: Tue, 25 Nov 2025 15:47:39 -0600	[thread overview]
Message-ID: <20251125214739.GA59583@mac.lan> (raw)
In-Reply-To: <2d7f50d1-36f0-452c-9bbe-4baaf7da34ce@huawei.com>

On Thu, Nov 06, 2025 at 10:59:22AM +0800, Sun Yongjian wrote:
> 
> Thanks a lot for pointing out the logical flaw! Yes, you’re right—if order-0
> bit pair is clear, then without a single 0 showing up at any higher order
> we’ll never enter the `if` branch to run `MB_CHECK_ASSERT`. The code you
> proposed is indeed a better, more elegant implementation!

Were you planning on sending a revised version of this patch set with
the suggested change?

Thanks,

						- Ted

  reply	other threads:[~2025-11-25 21:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-05  7:42 [PATCH 0/2] ext4: fixes for mb_check_buddy integrity checks Yongjian Sun
2025-11-05  7:42 ` [PATCH 1/2] ext4: fix incorrect group number assertion in mb_check_buddy for exhausted preallocations Yongjian Sun
2025-11-05 11:19   ` Jan Kara
2025-11-05  7:42 ` [PATCH 2/2] ext4: improve integrity checking in __mb_check_buddy by enhancing order-0 validation Yongjian Sun
2025-11-05 12:04   ` Jan Kara
2025-11-06  2:59     ` Sun Yongjian
2025-11-25 21:47       ` Theodore Tso [this message]
2025-11-26  9:12         ` Sun Yongjian
2025-11-26 19:38           ` Theodore Tso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251125214739.GA59583@mac.lan \
    --to=tytso@mit.edu \
    --cc=chengzhihao1@huawei.com \
    --cc=jack@suse.cz \
    --cc=libaokun1@huawei.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=sunyongjian1@huawei.com \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.