From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A5DBD0E6C7 for ; Tue, 25 Nov 2025 11:49:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=38eIWhaY5NLrA7BHTFTIsru6tCu9JxdlgVj7uaczlzc=; b=xWLyJ87G5/c2c0VyJ039SUiHyA Ljso8iYPoJ8mhqGpF67MHdVZfYoZVpkzTwyaUstvRWHafSaz4EKh419rrGr9ph1jvcsn1jpvZkAJw /Yj3kPycCLWMp17i+Y2+YSKWZEZ41MV74qtKS5W1g0vhkRi4EmLFAUsHTN699ovH2a36lZpWmnqO7 ZZq9rSYrAF64Szvtk55p0ZM1UlUlsTcwtfkDMpy0/Kj+zr3LeZd0vVB+myvOxFLTNg5pWDehVsFiQ CuZwmLHy028bdImZuXV9R6CbkmVUS6x5fuww3uaAmdnVaEMP6zwBl+ue5qdIZ6aBax8hwzz4ZDuP+ RyP3RgkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNrY8-0000000DF04-2JZJ; Tue, 25 Nov 2025 11:49:36 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNrY6-0000000DEzb-1XLI; Tue, 25 Nov 2025 11:49:35 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 2FA9C40706; Tue, 25 Nov 2025 11:49:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82664C4CEF1; Tue, 25 Nov 2025 11:49:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1764071373; bh=kcfJPaV0RlJNuRv5orxjsEuIYQsBEO264pipegKAgKM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RrRKFlYdNjpuJAzVmv+xPBFxiA66JbJHRfceWAvEnfly2ci3y3+LUqgq7ypKZ3EBu jCig9MZM3yIaUBXdD2UdwBQ+NXk4DQLPLPcSj7Zpz/ujmoxxNN0aoLYjvcXMfeqqDM 7JpcLbcGUGvGymYalc0d08j3Mz81qcwvyaIUpz2o= Date: Tue, 25 Nov 2025 12:49:29 +0100 From: Greg Kroah-Hartman To: Heikki Krogerus Cc: Chaoyi Chen , Chaoyi Chen , Dmitry Baryshkov , Peter Chen , Luca Ceresoli , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Sandy Huang , Andy Yan , Yubing Zhang , Frank Wang , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Amit Sunil Dhamne , Dragan Simic , Johan Jonker , Diederik de Haas , Peter Robinson , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v10 01/11] usb: typec: Add notifier functions Message-ID: <2025112554-uncaring-curator-642a@gregkh> References: <20251120022343.250-1-kernel@airkyi.com> <20251120022343.250-2-kernel@airkyi.com> <2025112102-laurel-mulch-58e4@gregkh> <462ad1bd-7eec-4f26-b383-96b049e14559@rock-chips.com> <2025112402-unopposed-polio-e6e9@gregkh> <2025112448-brush-porcupine-c851@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251125_034934_426347_F5F2F993 X-CRM114-Status: UNSURE ( 7.03 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > +static umode_t typec_is_visible(struct kobject *kobj, struct attribute *attr, int n) > +{ > + if (is_typec_port(kobj_to_dev(kobj)->parent)) Why look at the parent? Doesn't the device have a type that should show this? Otherwise, looks good to me. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93F8AD0E6C7 for ; Tue, 25 Nov 2025 11:49:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5XncvKMFr9zNZJd+BLwDJ3GSiUQKjTrgtDti8XcIdfg=; b=p3uSVwSKPQXhUJ mA8DTIq0tXvu+wMLl8GFtp7LNVejDVAcKQcUmMeGxFYAyVytwBv2furNHc5SYTXh6V1kQnDUbWfYf pDg9UKm00/23WSHQpIAwbWXfduSxnpgo0Aty0k5WO+J60vD/naQSKLSM9baPzeitS9z7Gi9TT7plK Bv47n1O/hQIs4hTljJVdP6kmbmqrrzvKhxvAxfx8qaprUg40ZMmgyA9dwZNeMvpmF8Yuk5t93K6MH eNXaQ0ryAhZU9FY2+WDpknzxZx970YWWQaF4n7j/jNO2QBDITXq9qoDD/O37lmf7l17PZ+3oHQ6iW Ol79Y9YIrzPyJuC5wWAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNrY9-0000000DF0b-1RvX; Tue, 25 Nov 2025 11:49:37 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNrY6-0000000DEzb-1XLI; Tue, 25 Nov 2025 11:49:35 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 2FA9C40706; Tue, 25 Nov 2025 11:49:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82664C4CEF1; Tue, 25 Nov 2025 11:49:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1764071373; bh=kcfJPaV0RlJNuRv5orxjsEuIYQsBEO264pipegKAgKM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RrRKFlYdNjpuJAzVmv+xPBFxiA66JbJHRfceWAvEnfly2ci3y3+LUqgq7ypKZ3EBu jCig9MZM3yIaUBXdD2UdwBQ+NXk4DQLPLPcSj7Zpz/ujmoxxNN0aoLYjvcXMfeqqDM 7JpcLbcGUGvGymYalc0d08j3Mz81qcwvyaIUpz2o= Date: Tue, 25 Nov 2025 12:49:29 +0100 From: Greg Kroah-Hartman To: Heikki Krogerus Cc: Chaoyi Chen , Chaoyi Chen , Dmitry Baryshkov , Peter Chen , Luca Ceresoli , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Sandy Huang , Andy Yan , Yubing Zhang , Frank Wang , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Amit Sunil Dhamne , Dragan Simic , Johan Jonker , Diederik de Haas , Peter Robinson , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v10 01/11] usb: typec: Add notifier functions Message-ID: <2025112554-uncaring-curator-642a@gregkh> References: <20251120022343.250-1-kernel@airkyi.com> <20251120022343.250-2-kernel@airkyi.com> <2025112102-laurel-mulch-58e4@gregkh> <462ad1bd-7eec-4f26-b383-96b049e14559@rock-chips.com> <2025112402-unopposed-polio-e6e9@gregkh> <2025112448-brush-porcupine-c851@gregkh> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251125_034934_426347_F5F2F993 X-CRM114-Status: UNSURE ( 7.03 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org > +static umode_t typec_is_visible(struct kobject *kobj, struct attribute *attr, int n) > +{ > + if (is_typec_port(kobj_to_dev(kobj)->parent)) Why look at the parent? Doesn't the device have a type that should show this? Otherwise, looks good to me. thanks, greg k-h -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0E38D0E6C4 for ; Tue, 25 Nov 2025 11:49:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Shu2CipXVHfs4yzGdDMlmunuK9PLIA+gteA+jqHo3fA=; b=hrkv2+u/Ec09xU EGNqC5hH7QsId+lAC4vTGr11URUfjxmlwAEmMjG1iQB27NdeaO3PVPGlfNdvzqxCishyT/CiDML0R y/uyCS5jKu2L1yF9Td+NDgf6OxlNs+6EXR/XcflgQj0mVB70etuchNtHdbde6noE1YL0o+QUusKvE /B7Qu+p0AUlkXDN/ZVMYwB6XnIPK6Mb3U56ONw7Z7L1Ull8h+LDaJR0vLtkr88cr5KnVINCGwNcRv FZbxNN8agQD0fe2n9vR7Dg283MCRPn8kdBBDWruLxWoHUvVN5vihglo6f2Ti6PEmwiGuzMfiTEZvI LPYNmxDcPXC582RnRtLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNrY9-0000000DF0l-2UGT; Tue, 25 Nov 2025 11:49:37 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNrY6-0000000DEzb-1XLI; Tue, 25 Nov 2025 11:49:35 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 2FA9C40706; Tue, 25 Nov 2025 11:49:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82664C4CEF1; Tue, 25 Nov 2025 11:49:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1764071373; bh=kcfJPaV0RlJNuRv5orxjsEuIYQsBEO264pipegKAgKM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RrRKFlYdNjpuJAzVmv+xPBFxiA66JbJHRfceWAvEnfly2ci3y3+LUqgq7ypKZ3EBu jCig9MZM3yIaUBXdD2UdwBQ+NXk4DQLPLPcSj7Zpz/ujmoxxNN0aoLYjvcXMfeqqDM 7JpcLbcGUGvGymYalc0d08j3Mz81qcwvyaIUpz2o= Date: Tue, 25 Nov 2025 12:49:29 +0100 From: Greg Kroah-Hartman To: Heikki Krogerus Cc: Chaoyi Chen , Chaoyi Chen , Dmitry Baryshkov , Peter Chen , Luca Ceresoli , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Sandy Huang , Andy Yan , Yubing Zhang , Frank Wang , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Amit Sunil Dhamne , Dragan Simic , Johan Jonker , Diederik de Haas , Peter Robinson , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v10 01/11] usb: typec: Add notifier functions Message-ID: <2025112554-uncaring-curator-642a@gregkh> References: <20251120022343.250-1-kernel@airkyi.com> <20251120022343.250-2-kernel@airkyi.com> <2025112102-laurel-mulch-58e4@gregkh> <462ad1bd-7eec-4f26-b383-96b049e14559@rock-chips.com> <2025112402-unopposed-polio-e6e9@gregkh> <2025112448-brush-porcupine-c851@gregkh> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251125_034934_426347_F5F2F993 X-CRM114-Status: UNSURE ( 7.03 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org > +static umode_t typec_is_visible(struct kobject *kobj, struct attribute *attr, int n) > +{ > + if (is_typec_port(kobj_to_dev(kobj)->parent)) Why look at the parent? Doesn't the device have a type that should show this? Otherwise, looks good to me. thanks, greg k-h _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip