From: Stephen Hemminger <stephen@networkplumber.org>
To: a.schollmeyer@syseleven.de
Cc: Aman Singh <aman.deep.singh@intel.com>, dev@dpdk.org
Subject: Re: [PATCH v2] app/testpmd: warn on shared rxq switch mismatch
Date: Wed, 26 Nov 2025 07:02:17 -0800 [thread overview]
Message-ID: <20251126070217.2b127bac@phoenix.local> (raw)
In-Reply-To: <20251126104009.472852-1-a.schollmeyer@syseleven.de>
On Wed, 26 Nov 2025 11:40:09 +0100
a.schollmeyer@syseleven.de wrote:
> + if (mismatch) {
> + fprintf(stderr, "Bad shared rxq config: "
> + "%s mismatch in share group/qid %u/%u: "
It is better to not split formats across lines.
Can you shorten it, and put on oneline.
Despite what checkpatch may say, you can make that a longish line like 200 characters.
Also, maybe break from the loop on first mismatch? and return an error?
Then message can be outside the loop.
next prev parent reply other threads:[~2025-11-26 15:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 10:22 [PATCH] app/testpmd: warn on shared rxq switch mismatch a.schollmeyer
2025-11-25 14:30 ` Stephen Hemminger
2025-11-26 10:40 ` [PATCH v2] " a.schollmeyer
2025-11-26 15:02 ` Stephen Hemminger [this message]
2025-12-01 10:22 ` [PATCH v3] app/testpmd: fail " a.schollmeyer
2025-12-02 23:53 ` Stephen Hemminger
2026-03-23 13:46 ` Dariusz Sosnowski
2026-03-23 16:17 ` [PATCH] app/testpmd: warn " Stephen Hemminger
2026-03-24 9:04 ` Dariusz Sosnowski
2026-03-25 13:04 ` Adrian Schollmeyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251126070217.2b127bac@phoenix.local \
--to=stephen@networkplumber.org \
--cc=a.schollmeyer@syseleven.de \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.