Re: [PATCH net-next v12 07/12] virtio_net: Implement layer 2 ethtool flow rules

["Michael S. Tsirkin" <mst@redhat.com>]

On Wed, Nov 26, 2025 at 10:25:44AM -0600, Dan Jurgens wrote:
> On 11/24/25 3:05 PM, Michael S. Tsirkin wrote:
> > On Wed, Nov 19, 2025 at 01:15:18PM -0600, Daniel Jurgens wrote:
> >> @@ -5681,6 +5710,7 @@ static const struct ethtool_ops virtnet_ethtool_ops = {
> >>  	.get_rxfh_fields = virtnet_get_hashflow,
> >>  	.set_rxfh_fields = virtnet_set_hashflow,
> >>  	.get_rx_ring_count = virtnet_get_rx_ring_count,
> >> +	.set_rxnfc = virtnet_set_rxnfc,
> >>  };
> >>  
> >>  static void virtnet_get_queue_stats_rx(struct net_device *dev, int i,
> > 
> > should we not wire up get_rxnfc too? weird to be able to set but
> > not get.
> > 
> 
> I prefer to do that as the last patch. That's what really turn the
> feature on. ethtool need to do gets before it can set. Also, this patch
> is already quite large.


ok