From: Stephen Hemminger <stephen@networkplumber.org>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: dev@dpdk.org, zaiyuwang@trustnetic.com
Subject: Re: [PATCH v2] net/txgbe: fix the missing old mailbox interface calls
Date: Wed, 26 Nov 2025 13:43:32 -0800 [thread overview]
Message-ID: <20251126134332.77ae1685@phoenix.local> (raw)
In-Reply-To: <9E296F0580980C92+20251126085649.8665-1-jiawenwu@trustnetic.com>
On Wed, 26 Nov 2025 16:56:49 +0800
Jiawen Wu <jiawenwu@trustnetic.com> wrote:
> For different devices, the mailbox flow between software and firmware is
> different. There are several mailbox command in the txgbe driver, but only
> txgbe_hic_sr_read() was changed to use the new flow.
>
> It lead to other mailbox commands timeout for Amber-Lite devices, which
> is required to use the new flow. So this patch fills in the missing part.
>
> For the sake of code tidy, txgbe_hic_sr_read() should change to use the
> locked function txgbe_host_interface_command(), and this function could
> be change to pointer in struct txgbe_mbx_info for different devices.
>
> Fixes: 6a139ade82e7 ("net/txgbe: add new SW-FW mailbox interface")
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> ---
Queued to next-net
next prev parent reply other threads:[~2025-11-26 21:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 8:56 [PATCH] net/txgbe: fix the missing old mailbox interface calls Jiawen Wu
2025-11-20 5:47 ` Stephen Hemminger
2025-11-20 6:24 ` Jiawen Wu
2025-11-24 2:03 ` Jiawen Wu
2025-11-26 6:27 ` Jiawen Wu
2025-11-26 8:29 ` Thomas Monjalon
2025-11-26 8:56 ` [PATCH v2] " Jiawen Wu
2025-11-26 21:43 ` Stephen Hemminger [this message]
2025-11-27 17:57 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251126134332.77ae1685@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=zaiyuwang@trustnetic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.