From: Petr Vorel <pvorel@suse.cz>
To: Pavithra <pavrampu@linux.ibm.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/3] Adding magic definition required for hugemmap40.
Date: Thu, 27 Nov 2025 09:19:52 +0100 [thread overview]
Message-ID: <20251127081952.GA216010@pevik> (raw)
In-Reply-To: <20251127072231.2104445-2-pavrampu@linux.ibm.com>
Hi Pavithra,
...
> +++ b/include/tst_fs.h
> @@ -33,6 +33,7 @@
> #define TST_FUSE_MAGIC 0x65735546
> #define TST_VFAT_MAGIC 0x4d44 /* AKA MSDOS */
> #define TST_EXFAT_MAGIC 0x2011BAB0UL
> +#define HUGETLBFS_MAGIC 0x958458f6
Could you please use "TST_" prefix for that definition (i.e.
TST_HUGETLBFS_MAGIC) as it is used for other LTP specific definitions?
That way we avoid constant redefinition in case of including <linux/magic.h>.
With that you may add:
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-11-27 8:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 7:22 [LTP] [PATCH 1/3] Adding new function read_maps required for hugemmap40 Pavithra
2025-11-27 7:22 ` [LTP] [PATCH 2/3] Adding magic definition " Pavithra
2025-11-27 8:19 ` Petr Vorel [this message]
2025-11-27 7:22 ` [LTP] [PATCH 3/3] [PATCH] [PATCH] Migrating the libhugetlbfs/testcases/straddle_4GB.c v3 Pavithra
2025-11-27 11:33 ` Petr Vorel
2025-11-27 10:31 ` [LTP] [PATCH 1/3] Adding new function read_maps required for hugemmap40 Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251127081952.GA216010@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pavrampu@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.