From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55CA732BF40; Thu, 27 Nov 2025 14:58:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764255532; cv=none; b=q+O0TgelJ7tIcR6LxvuKbzloTgQW/Nz5wvLSbSbwu1LwrHDEGBsruVKwGBXtGykSIaxGXmlhy+r+mtpl8p+T/3o5bQqD46x1WzvVMoySc0Yx52FxkT6XEumgi1mRtieAbgovOgacePE10DjZrJzj4GWKfaJDPV7fzlIW8gtd2qY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764255532; c=relaxed/simple; bh=i+wsHf7kuHlnLlJYFuBAQvGYM+bGPNBHhSWsM6wtVGw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H9tr7C6M8B0+Qvqrv6K4yso3H0dy5VE2KMogQYXy5bF52O0BRf/d7LBFQ/QGdJnHR/XK1b9EyAt2CNC+GNPiDPaMAhHoSm7akhb3Mm2Etb+xo8eqXeW58VN00jas3n2UOousqyAxdelQ66uoPDn3wlEXDUajkxwy2XbLoqGFgA0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=owMhsRHo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="owMhsRHo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD853C4CEF8; Thu, 27 Nov 2025 14:58:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1764255532; bh=i+wsHf7kuHlnLlJYFuBAQvGYM+bGPNBHhSWsM6wtVGw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=owMhsRHov+mPDrgNpinIQ9UklfBjHu7pRwLu5aWPo9INF8NiSqOtCd63sy9Q8DMJr 9ybJkSRw61dbrr2WbPlmbTVoqdTTXX+mFejBh4dTSa68/ROKh4N+TQ8isJNfyXLntQ Ho6Qk23qS2VcIeONeEEONvTTRhS6bn9ABxoxE6rc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Titas , "Mario Limonciello (AMD)" , Jiri Kosina Subject: [PATCH 6.17 004/175] HID: amd_sfh: Stop sensor before starting Date: Thu, 27 Nov 2025 15:44:17 +0100 Message-ID: <20251127144043.110872213@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251127144042.945669935@linuxfoundation.org> References: <20251127144042.945669935@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.17-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mario Limonciello (AMD) commit 4d3a13afa8b64dc49293b3eab3e7beac11072c12 upstream. Titas reports that the accelerometer sensor on their laptop only works after a warm boot or unloading/reloading the amd-sfh kernel module. Presumably the sensor is in a bad state on cold boot and failing to start, so explicitly stop it before starting. Cc: stable@vger.kernel.org Fixes: 93ce5e0231d79 ("HID: amd_sfh: Implement SFH1.1 functionality") Reported-by: Titas Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220670 Tested-by: Titas Signed-off-by: Mario Limonciello (AMD) Signed-off-by: Jiri Kosina Signed-off-by: Greg Kroah-Hartman --- drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c +++ b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c @@ -194,6 +194,8 @@ static int amd_sfh1_1_hid_client_init(st if (rc) goto cleanup; + mp2_ops->stop(privdata, cl_data->sensor_idx[i]); + amd_sfh_wait_for_response(privdata, cl_data->sensor_idx[i], DISABLE_SENSOR); writel(0, privdata->mmio + amd_get_p2c_val(privdata, 0)); mp2_ops->start(privdata, info); status = amd_sfh_wait_for_response