From: Jakub Kicinski <kuba@kernel.org>
To: Clara Engler <cve@cve.cx>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, dsahern@kernel.org, edumazet@google.com,
pabeni@redhat.com, horms@kernel.org
Subject: Re: [PATCH] ipv4: Fix log message for martian source
Date: Thu, 27 Nov 2025 18:17:43 -0800 [thread overview]
Message-ID: <20251127181743.2bdf214b@kernel.org> (raw)
In-Reply-To: <aSd4Xj8rHrh-krjy@4944566b5c925f79>
On Wed, 26 Nov 2025 22:59:58 +0100 Clara Engler wrote:
> @@ -1796,7 +1796,7 @@ static void ip_handle_martian_source(struct net_device *dev,
> * the only hint is MAC header.
> */
> pr_warn("martian source %pI4 from %pI4, on dev %s\n",
> - &daddr, &saddr, dev->name);
> + &saddr, &daddr, dev->name);
imagine there was another comma in this print:
martian source, %pI4 from %pI4, on dev %s
we should leave it as is, I think.
People may be grepping logs for this exact format..
--
pw-bot: reject
next prev parent reply other threads:[~2025-11-28 2:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 21:59 [PATCH] ipv4: Fix log message for martian source Clara Engler
2025-11-28 2:17 ` Jakub Kicinski [this message]
2025-11-28 16:47 ` Clara Engler
2025-11-28 18:47 ` Jakub Kicinski
2025-12-01 18:54 ` Clara Engler
2025-12-01 19:40 ` Jakub Kicinski
2025-12-01 21:35 ` Clara Engler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251127181743.2bdf214b@kernel.org \
--to=kuba@kernel.org \
--cc=cve@cve.cx \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.