All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Charles Keepax <ckeepax@opensource.cirrus.com>,
	stable@vger.kernel.org, linus.walleij@linaro.org,
	patches@opensource.cirrus.com
Subject: Re: [PATCH] Revert "gpio: swnode: don't use the swnode's name as the key for GPIO lookup"
Date: Thu, 27 Nov 2025 16:03:35 +0100	[thread overview]
Message-ID: <2025112726-bovine-snare-3147@gregkh> (raw)
In-Reply-To: <CAMRc=MegBo8vxEMd=9tt91SQie9u9_46Z00jzzZXGcvVQs5w5Q@mail.gmail.com>

On Thu, Nov 27, 2025 at 03:45:29PM +0100, Bartosz Golaszewski wrote:
> On Thu, Nov 27, 2025 at 3:17 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Thu, Nov 27, 2025 at 02:10:32PM +0000, Charles Keepax wrote:
> > > On Thu, Nov 27, 2025 at 03:07:48PM +0100, Greg KH wrote:
> > > > On Thu, Nov 27, 2025 at 02:04:48PM +0000, Charles Keepax wrote:
> > > > > On Thu, Nov 27, 2025 at 02:51:50PM +0100, Greg KH wrote:
> > > > > > On Tue, Nov 25, 2025 at 12:49:59PM +0000, Charles Keepax wrote:
> > > > > > > On Tue, Nov 25, 2025 at 12:58:30PM +0100, Greg KH wrote:
> > > > > > > > On Tue, Nov 25, 2025 at 11:48:02AM +0000, Charles Keepax wrote:
> > > > > > > > > On Tue, Nov 25, 2025 at 12:43:16PM +0100, Greg KH wrote:
> > > > > > > > > > On Tue, Nov 25, 2025 at 11:31:56AM +0100, Bartosz Golaszewski wrote:
> > > > > > > > > > > On Tue, Nov 25, 2025 at 11:29 AM Charles Keepax
> > > > > > > > > > > <ckeepax@opensource.cirrus.com> wrote:
> > > > > > > Do we have to wait for the fixes to hit Linus's tree before
> > > > > > > pushing them to stable? As they are still in Philipp Zabel's
> > > > > > > reset tree at the moment and I would quite like to stem the
> > > > > > > rising tide of tickets I am getting about audio breaking on
> > > > > > > peoples laptops as soon as possible.
> > > > > >
> > > > > > Yes, we need the fixes there first.
> > > > >
> > > > > Fair enough, but it is super sad that everyone has to sit around
> > > > > with broken devices until after the merge window. This is not a
> > > > > theoretical issue people are complaining about this now.
> > > >
> > > > Are people sitting around with this issue in 6.18-rc releases now?  Is
> > > > 6.18-final going to be broken in the same way?
> > >
> > > Yeah regrettably that is going to be broken too, at least until
> > > the first stable release either does the same revert or backports
> > > the same fixes.
> >
> > Great, we are "bug compatible!"  :)
> >
> > Seriously, this happens for minor things all the time, not that big of a
> > deal normally.
> >
> 
> Just my two cents: this feature interacts quite a lot with another new
> feature: shared GPIOs in GPIOLIB. I've already either queued or have
> under review ~7 other fixes. Since in stable, the code from this
> series would not interact with gpiolib-shared (because no way this
> should get backported), we'd still have a bit of a different
> environment in mainline and stable branches.
> 
> I would very much prefer to revert the patch in question than worry
> about divergences in logic.

Ok, fair enough, now reverted!

thanks,

greg k-h

  reply	other threads:[~2025-11-27 15:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-25 10:29 [PATCH] Revert "gpio: swnode: don't use the swnode's name as the key for GPIO lookup" Charles Keepax
2025-11-25 10:31 ` Bartosz Golaszewski
2025-11-25 10:49   ` Charles Keepax
2025-11-25 11:43   ` Greg KH
2025-11-25 11:48     ` Charles Keepax
2025-11-25 11:58       ` Greg KH
2025-11-25 12:49         ` Charles Keepax
2025-11-27 13:51           ` Greg KH
2025-11-27 14:04             ` Charles Keepax
2025-11-27 14:07               ` Greg KH
2025-11-27 14:10                 ` Charles Keepax
2025-11-27 14:17                   ` Greg KH
2025-11-27 14:45                     ` Bartosz Golaszewski
2025-11-27 15:03                       ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-12-16 13:30 Charles Keepax

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025112726-bovine-snare-3147@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=brgl@bgdev.pl \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=linus.walleij@linaro.org \
    --cc=patches@opensource.cirrus.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.