From: "Benoît Monin" <benoit.monin@bootlin.com>
To: linux-i2c@vger.kernel.org
Cc: "Jean Delvare" <jdelvare@suse.de>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Benoît Monin" <benoit.monin@bootlin.com>
Subject: [PATCH i2c-tools 2/2] i2ctransfer: Add optional message modifier flags
Date: Fri, 28 Nov 2025 11:40:10 +0100 [thread overview]
Message-ID: <20251128-msg-flags-v1-2-6353f26fa6bc@bootlin.com> (raw)
In-Reply-To: <20251128-msg-flags-v1-0-6353f26fa6bc@bootlin.com>
Allow setting protocol mangling and repeated start elision flags of an i2c
message with a set of optional command-line flags. These optional flags
are parsed at the beginning of the DESC field up to a read or write flag.
For example, to read one byte from address 0x50 followed by a stop, then
write two bytes at 0x54 on bus 0, one would call i2ctransfer as follow:
i2ctransfer 0 pr1@0x50 w2@0x54 0x10 0x20
Since the new flags are optional, this patch preserves the compatibility
of the i2ctransfer syntax.
Signed-off-by: Benoît Monin <benoit.monin@bootlin.com>
---
tools/i2ctransfer.c | 34 +++++++++++++++++++++++++---------
1 file changed, 25 insertions(+), 9 deletions(-)
diff --git a/tools/i2ctransfer.c b/tools/i2ctransfer.c
index 4db98e3..921ffaa 100644
--- a/tools/i2ctransfer.c
+++ b/tools/i2ctransfer.c
@@ -52,9 +52,16 @@ static void help(void)
" -V version info\n"
" -y yes to all confirmations\n"
" I2CBUS is an integer or an I2C bus name\n"
- " DESC describes the transfer in the form: {r|w}LENGTH[@address]\n"
- " 1) read/write-flag 2) LENGTH (range 0-65535, or '?')\n"
- " 3) I2C address (use last one if omitted)\n"
+ " DESC describes the transfer in the form: [inpst]{r|w}LENGTH[@address]\n"
+ " 1) optional message modifier flags\n"
+ " i: ignore NACK from client\n"
+ " n: no master ACK/NACK bit in a read message\n"
+ " p: emit a STOP after the message\n"
+ " s: skip repeated start\n"
+ " t: toggle read/write bit\n"
+ " 2) mandatory read/write flag\n"
+ " 3) LENGTH (range 0-65535, or '?')\n"
+ " 4) I2C address (use last one if omitted)\n"
" DATA are LENGTH bytes for a write message. They can be shortened by a suffix:\n"
" = (keep value constant until LENGTH)\n"
" + (increase value by 1 until LENGTH)\n"
@@ -202,12 +209,21 @@ int main(int argc, char *argv[])
case PARSE_GET_DESC:
flags = 0;
- switch (*arg_ptr++) {
- case 'r': flags |= I2C_M_RD; break;
- case 'w': break;
- default:
- fprintf(stderr, "Error: Invalid direction\n");
- goto err_out_with_arg;
+ for (int done = 0; !done; ) {
+ switch (*arg_ptr++) {
+ /* optional flags */
+ case 'i': flags |= I2C_M_IGNORE_NAK; break;
+ case 'n': flags |= I2C_M_NO_RD_ACK; break;
+ case 'p': flags |= I2C_M_STOP; break;
+ case 's': flags |= I2C_M_NOSTART; break;
+ case 't': flags |= I2C_M_REV_DIR_ADDR; break;
+ /* mandatory flags */
+ case 'r': flags |= I2C_M_RD; done = 1; break;
+ case 'w': done = 1; break;
+ default:
+ fprintf(stderr, "Error: Invalid flag\n");
+ goto err_out_with_arg;
+ }
}
if (*arg_ptr == '?') {
--
2.52.0
prev parent reply other threads:[~2025-11-28 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 10:40 [PATCH i2c-tools 0/2] Add support for message modifier flags Benoît Monin
2025-11-28 10:40 ` [PATCH i2c-tools 1/2] i2cdetect: Display mangling and nostart support Benoît Monin
2025-11-28 10:40 ` Benoît Monin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251128-msg-flags-v1-2-6353f26fa6bc@bootlin.com \
--to=benoit.monin@bootlin.com \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.