From: Chaoyi Chen <kernel@airkyi.com>
To: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>
Cc: iommu@lists.linux.dev, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Chaoyi Chen <chaoyi.chen@rock-chips.com>
Subject: [PATCH v2 1/2] dt-bindings: iommu: rockchip: Add support for multiple interface clocks
Date: Fri, 28 Nov 2025 15:13:21 +0800 [thread overview]
Message-ID: <20251128071322.92-2-kernel@airkyi.com> (raw)
In-Reply-To: <20251128071322.92-1-kernel@airkyi.com>
From: Chaoyi Chen <chaoyi.chen@rock-chips.com>
The iommu found on RK3576 NPU and RK3576 RKVDEC have 4 clock instead of
2 clock. Their clock names might differ, but I don't think that matters
much.
Add support for them.
Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
---
Changes in v2:
- Rewrite dt binding.
.../bindings/iommu/rockchip,iommu.yaml | 52 ++++++++++++++++---
1 file changed, 46 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
index 6ce41d11ff5e..dfa5e25476d9 100644
--- a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
+++ b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
@@ -27,6 +27,8 @@ properties:
- enum:
- rockchip,rk3576-iommu
- rockchip,rk3588-iommu
+ - rockchip,rk3576-npu-iommu
+ - rockchip,rk3576-rkvdec-iommu
- const: rockchip,rk3568-iommu
reg:
@@ -42,14 +44,12 @@ properties:
minItems: 1
clocks:
- items:
- - description: Core clock
- - description: Interface clock
+ minItems: 2
+ maxItems: 4
clock-names:
- items:
- - const: aclk
- - const: iface
+ minItems: 2
+ maxItems: 4
"#iommu-cells":
const: 0
@@ -64,6 +64,46 @@ properties:
Some mmu instances may produce unexpected results
when the reset operation is used.
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - rockchip,rk3576-npu-iommu
+ - rockchip,rk3576-rkvdec-iommu
+ then:
+ properties:
+ clocks:
+ minItems: 4
+ clock-names:
+ minItems: 4
+ - if:
+ properties:
+ compatible:
+ items:
+ - const: rockchip,iommu
+ - const: rockchip,rk3568-iommu
+ then:
+ properties:
+ clocks:
+ maxItems: 2
+ clock-names:
+ maxItems: 2
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - rockchip,rk3576-iommu
+ - rockchip,rk3588-iommu
+ then:
+ properties:
+ clocks:
+ maxItems: 2
+ clock-names:
+ maxItems: 2
+
required:
- compatible
- reg
--
2.51.1
WARNING: multiple messages have this Message-ID (diff)
From: Chaoyi Chen <kernel@airkyi.com>
To: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>
Cc: iommu@lists.linux.dev, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Chaoyi Chen <chaoyi.chen@rock-chips.com>
Subject: [PATCH v2 1/2] dt-bindings: iommu: rockchip: Add support for multiple interface clocks
Date: Fri, 28 Nov 2025 15:13:21 +0800 [thread overview]
Message-ID: <20251128071322.92-2-kernel@airkyi.com> (raw)
In-Reply-To: <20251128071322.92-1-kernel@airkyi.com>
From: Chaoyi Chen <chaoyi.chen@rock-chips.com>
The iommu found on RK3576 NPU and RK3576 RKVDEC have 4 clock instead of
2 clock. Their clock names might differ, but I don't think that matters
much.
Add support for them.
Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
---
Changes in v2:
- Rewrite dt binding.
.../bindings/iommu/rockchip,iommu.yaml | 52 ++++++++++++++++---
1 file changed, 46 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
index 6ce41d11ff5e..dfa5e25476d9 100644
--- a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
+++ b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
@@ -27,6 +27,8 @@ properties:
- enum:
- rockchip,rk3576-iommu
- rockchip,rk3588-iommu
+ - rockchip,rk3576-npu-iommu
+ - rockchip,rk3576-rkvdec-iommu
- const: rockchip,rk3568-iommu
reg:
@@ -42,14 +44,12 @@ properties:
minItems: 1
clocks:
- items:
- - description: Core clock
- - description: Interface clock
+ minItems: 2
+ maxItems: 4
clock-names:
- items:
- - const: aclk
- - const: iface
+ minItems: 2
+ maxItems: 4
"#iommu-cells":
const: 0
@@ -64,6 +64,46 @@ properties:
Some mmu instances may produce unexpected results
when the reset operation is used.
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - rockchip,rk3576-npu-iommu
+ - rockchip,rk3576-rkvdec-iommu
+ then:
+ properties:
+ clocks:
+ minItems: 4
+ clock-names:
+ minItems: 4
+ - if:
+ properties:
+ compatible:
+ items:
+ - const: rockchip,iommu
+ - const: rockchip,rk3568-iommu
+ then:
+ properties:
+ clocks:
+ maxItems: 2
+ clock-names:
+ maxItems: 2
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - rockchip,rk3576-iommu
+ - rockchip,rk3588-iommu
+ then:
+ properties:
+ clocks:
+ maxItems: 2
+ clock-names:
+ maxItems: 2
+
required:
- compatible
- reg
--
2.51.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-11-28 7:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 7:13 [PATCH v2 0/2] iommu/rockchip: Add support for multiple interface clocks Chaoyi Chen
2025-11-28 7:13 ` Chaoyi Chen
2025-11-28 7:13 ` Chaoyi Chen [this message]
2025-11-28 7:13 ` [PATCH v2 1/2] dt-bindings: iommu: rockchip: " Chaoyi Chen
2025-11-28 8:18 ` Rob Herring (Arm)
2025-11-28 8:18 ` Rob Herring (Arm)
2025-12-01 7:55 ` Krzysztof Kozlowski
2025-12-01 7:55 ` Krzysztof Kozlowski
2025-12-01 8:10 ` Chaoyi Chen
2025-12-01 8:10 ` Chaoyi Chen
2025-12-01 8:39 ` Krzysztof Kozlowski
2025-12-01 8:39 ` Krzysztof Kozlowski
2025-12-01 8:54 ` Chaoyi Chen
2025-12-01 8:54 ` Chaoyi Chen
2025-11-28 7:13 ` [PATCH v2 2/2] iommu/rockchip: Use devm_clk_bulk_get_all() to get multiple iface clock Chaoyi Chen
2025-11-28 7:13 ` Chaoyi Chen
2025-11-28 7:31 ` Shawn Lin
2025-11-28 7:31 ` Shawn Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251128071322.92-2-kernel@airkyi.com \
--to=kernel@airkyi.com \
--cc=chaoyi.chen@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.