From: Jakub Kicinski <kuba@kernel.org>
To: Matthieu Baerts <matttbe@kernel.org>
Cc: Ankit Khushwaha <ankitkhushwaha.linux@gmail.com>,
netdev@vger.kernel.org, mptcp@lists.linux.dev,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, Shuah Khan <shuah@kernel.org>,
Mat Martineau <martineau@kernel.org>,
Geliang Tang <geliang@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>
Subject: Re: [PATCH] selftests: mptcp: initialize raw_addr to Null
Date: Fri, 28 Nov 2025 10:40:57 -0800 [thread overview]
Message-ID: <20251128104057.047704b5@kernel.org> (raw)
In-Reply-To: <603f6c4f-20a1-4b6b-80a8-c9d9d3373d7e@kernel.org>
On Fri, 28 Nov 2025 11:34:38 +0100 Matthieu Baerts wrote:
> > Including kselftest.h will be needed.
>
> Because mptcp_connect.c is a tool that is used by other selftests, but
> it doesn't interact directly with the selftests, maybe we don't need to
> include it, and only add this #define in mptcp_connect.c?
>
> #define __noreturn __attribute__((__noreturn__))
Up to you, I'd be worried that some semi-automated patch generator will
send us a "cleanup" to remove this as duplication. But I'm overly
sensitive to this sort of followups so we can try if you prefer :)
next prev parent reply other threads:[~2025-11-28 18:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 16:30 [PATCH] selftests: mptcp: initialize raw_addr to Null Ankit Khushwaha
2025-11-26 16:55 ` Matthieu Baerts
2025-11-28 1:00 ` Jakub Kicinski
2025-11-28 10:34 ` Matthieu Baerts
2025-11-28 18:40 ` Jakub Kicinski [this message]
2025-11-26 17:47 ` MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251128104057.047704b5@kernel.org \
--to=kuba@kernel.org \
--cc=ankitkhushwaha.linux@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=horms@kernel.org \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=morbo@google.com \
--cc=mptcp@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.