From: david laight <david.laight@runbox.com>
To: David Yang <mmyangfl@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/4] net: dsa: yt921x: Use *_ULL bitfield macros for VLAN_CTRL
Date: Fri, 28 Nov 2025 10:51:41 +0000 [thread overview]
Message-ID: <20251128105141.50188c6f@pumpkin> (raw)
In-Reply-To: <20251126093240.2853294-2-mmyangfl@gmail.com>
On Wed, 26 Nov 2025 17:32:34 +0800
David Yang <mmyangfl@gmail.com> wrote:
> VLAN_CTRL should be treated as a 64-bit register. GENMASK and BIT
> macros use unsigned long as the underlying type, which will result in a
> build error on architectures where sizeof(long) == 4.
I suspect GENMASK() should generate u32 or u64 depending on the value
of a constant 'high bit'.
I found code elsewhere that doesn't really want FIELD_PREP() to
generate a 64bit value.
There are actually a lot of dubious uses of 'long' throughout
the kernel that break on 32bit.
(Actually pretty much all of them!)
David
next prev parent reply other threads:[~2025-11-28 10:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 9:32 [PATCH net-next v3 0/4] net: dsa: yt921x: Add STP/MST/HSR/LAG support David Yang
2025-11-26 9:32 ` [PATCH net-next v3 1/4] net: dsa: yt921x: Use *_ULL bitfield macros for VLAN_CTRL David Yang
2025-11-28 1:58 ` Jakub Kicinski
2025-11-28 10:51 ` david laight [this message]
2025-11-28 11:43 ` Russell King (Oracle)
2025-11-28 19:25 ` david laight
2025-11-26 9:32 ` [PATCH net-next v3 2/4] net: dsa: yt921x: Add STP/MST support David Yang
2025-11-26 9:32 ` [PATCH net-next v3 3/4] net: dsa: yt921x: Add HSR offloading support David Yang
2025-11-26 16:26 ` Vladimir Oltean
2025-11-26 9:32 ` [PATCH net-next v3 4/4] net: dsa: yt921x: Add LAG " David Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251128105141.50188c6f@pumpkin \
--to=david.laight@runbox.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mmyangfl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.