From: Nathan Chancellor <nathan@kernel.org>
To: Nicolas Schier <nsc@kernel.org>
Cc: Kees Cook <kees@kernel.org>, WangYuli <wangyuli@aosc.io>,
WangYuli <wangyl5933@chinaunicom.cn>,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org,
Nicolas Schier <nicolas.schier@linux.dev>
Subject: Re: [PATCH 1/2] fortify: Rename temporary file to match ignore pattern
Date: Mon, 1 Dec 2025 16:41:05 -0700 [thread overview]
Message-ID: <20251201234105.GB2018462@ax162> (raw)
In-Reply-To: <20251128-fortify-improve-handling-of-tempfile-v1-1-a79d0d3abcac@kernel.org>
On Fri, Nov 28, 2025 at 08:27:57PM +0100, Nicolas Schier wrote:
> From: Nicolas Schier <nicolas.schier@linux.dev>
>
> test_fortify.sh uses a temporary file that might appear as untracked
> file in some rare sitations. Rename it to match one of top-level's
> gitignore patterns.
>
> Reported-by: WangYuli <wangyuli@aosc.io>
> Closes: https://lore.kernel.org/linux-kbuild/20251112114725.287349-1-wangyuli@aosc.io/
> Signed-off-by: Nicolas Schier <n.schier@avm.de>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Not a big problem but some tools might complain about the email mismatch
between the From: line (which will end up being the author) and the
Signed-off-by line.
> ---
> lib/test_fortify/test_fortify.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/test_fortify/test_fortify.sh b/lib/test_fortify/test_fortify.sh
> index c2688ab8281d..368d07d9acbf 100644
> --- a/lib/test_fortify/test_fortify.sh
> +++ b/lib/test_fortify/test_fortify.sh
> @@ -17,7 +17,7 @@ WANT="__${FILE%%-*}"
> # Argument 2: Where to write the build log.
> OUT="$1"
> shift
> -TMP="${OUT}.tmp"
> +TMP="${OUT%/*}/.${OUT##*/}.tmp"
>
> # Argument 3: Path to "nm" tool.
> NM="$1"
>
> --
> 2.51.0
>
next prev parent reply other threads:[~2025-12-01 23:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 19:27 [PATCH 0/2] fortify: test_fortify.sh: Improve handling of tempfile Nicolas Schier
2025-11-28 19:27 ` [PATCH 1/2] fortify: Rename temporary file to match ignore pattern Nicolas Schier
2025-12-01 1:55 ` WangYuli
2025-12-01 23:41 ` Nathan Chancellor [this message]
2025-11-28 19:27 ` [PATCH 2/2] fortify: Cleanup temp file also on non-successful exit Nicolas Schier
2025-12-01 1:56 ` WangYuli
2025-12-01 23:43 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251201234105.GB2018462@ax162 \
--to=nathan@kernel.org \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.schier@linux.dev \
--cc=nsc@kernel.org \
--cc=wangyl5933@chinaunicom.cn \
--cc=wangyuli@aosc.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.