From: Stephen Hemminger <stephen@networkplumber.org>
To: Shani Peretz <shperetz@nvidia.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>,
Aman Singh <aman.deep.singh@intel.com>,
Gregory Etelson <getelson@nvidia.com>,
Dariusz Sosnowski <dsosnowski@nvidia.com>
Subject: Re: [PATCH] app/testpmd: fix memory leak in port attach
Date: Tue, 2 Dec 2025 15:48:40 -0800 [thread overview]
Message-ID: <20251202154840.5579f76a@phoenix.local> (raw)
In-Reply-To: <20251202095720.264195-1-shperetz@nvidia.com>
On Tue, 2 Dec 2025 11:57:20 +0200
Shani Peretz <shperetz@nvidia.com> wrote:
> The convert_pci_address_format() function was leaking memory because
> rte_devargs_parse() allocates memory internally via strdup(), but the
> function never called rte_devargs_reset() to free it.
>
> Add a cleanup label to ensure rte_devargs_reset() is called on all
> return paths.
>
> Fixes: 12c2405989f6 ("app/testpmd: canonicalize short PCI name format")
> Fixes: acbff64ea5b1 ("app/testpmd: fix devargs format in port attach")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shani Peretz <shperetz@nvidia.com>
Queued to next-net for 26.03
prev parent reply other threads:[~2025-12-02 23:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 9:57 [PATCH] app/testpmd: fix memory leak in port attach Shani Peretz
2025-12-02 23:48 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251202154840.5579f76a@phoenix.local \
--to=stephen@networkplumber.org \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=getelson@nvidia.com \
--cc=shperetz@nvidia.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.