All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Dariusz Sosnowski <dsosnowski@nvidia.com>
Cc: Aman Singh <aman.deep.singh@intel.com>,
	Ori Kam <orika@nvidia.com>, <dev@dpdk.org>,
	Bing Zhao <bingz@nvidia.com>, <stable@dpdk.org>
Subject: Re: [PATCH] app/testpmd: fix flow queue job leaks
Date: Tue, 2 Dec 2025 16:04:06 -0800	[thread overview]
Message-ID: <20251202160406.2b166c90@phoenix.local> (raw)
In-Reply-To: <20251118104518.1714166-1-dsosnowski@nvidia.com>

On Tue, 18 Nov 2025 11:45:18 +0100
Dariusz Sosnowski <dsosnowski@nvidia.com> wrote:

> +	polled = 0;
> +	success = 0;
> +	while (expected_ops > 0) {
> +		/* Poisoning to make sure PMDs update it in case of error. */
> +		memset(&error, 0x55, sizeof(error));
> +		ret = rte_flow_pull(port_id, queue_id, res, expected_ops, &error);
> +		if (ret < 0) {
> +			port_flow_complain(&error);
> +			free(res);
> +			return ret;
> +		}
> +		if (ret == 0) {
> +			rte_delay_us_sleep(FLOW_QUEUE_FLUSH_SLEEP_US);
> +			continue;
> +		}

Infinite loops with sleep are bad. The poisoning seems unnecessary and not done
elsewhere. Sleeping for 10 us is just unlikely to help much.

  reply	other threads:[~2025-12-03  0:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-18 10:45 [PATCH] app/testpmd: fix flow queue job leaks Dariusz Sosnowski
2025-12-03  0:04 ` Stephen Hemminger [this message]
2026-01-08 15:54   ` Dariusz Sosnowski
2026-01-09 15:26 ` [PATCH v2] " Dariusz Sosnowski
2026-01-12  1:10   ` Stephen Hemminger
2026-01-12 17:41     ` Dariusz Sosnowski
2026-01-12 17:36   ` [PATCH v3] " Dariusz Sosnowski
2026-01-13  1:09     ` Stephen Hemminger
2026-02-03  9:41       ` Dariusz Sosnowski
2026-02-03  9:37     ` [PATCH v4] " Dariusz Sosnowski
2026-02-05 22:17       ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251202160406.2b166c90@phoenix.local \
    --to=stephen@networkplumber.org \
    --cc=aman.deep.singh@intel.com \
    --cc=bingz@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=dsosnowski@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.