All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Guanghui Feng <guanghuifeng@linux.alibaba.com>
Cc: bhelgaas@google.com,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	linux-pci@vger.kernel.org, alikernel-developer@linux.alibaba.com,
	"Lukas Wunner" <lukas@wunner.de>
Subject: Re: [PATCH v4 v4 1/1] PCI: Fix PCIe SBR dev/link wait error
Date: Tue, 2 Dec 2025 10:51:49 -0600	[thread overview]
Message-ID: <20251202165149.GA3077343@bhelgaas> (raw)
In-Reply-To: <20251202164900.GA3077274@bhelgaas>

[+cc Lukas (please always cc people who have commented on previous
iterations of your patch)]

On Tue, Dec 02, 2025 at 10:49:01AM -0600, Bjorn Helgaas wrote:
> On Tue, Dec 02, 2025 at 12:32:07PM +0800, Guanghui Feng wrote:
> > When executing a PCIe secondary bus reset, all downstream switches and
> > endpoints will generate reset events. Simultaneously, all PCIe links
> > will undergo retraining, and each link will independently re-execute the
> > LTSSM state machine training. Therefore, after executing the SBR, it is
> > necessary to wait for all downstream links and devices to complete
> > recovery. Otherwise, after the SBR returns, accessing devices with some
> > links or endpoints not yet fully recovered may result in driver errors,
> > or even trigger device offline issues.
> > 
> > Signed-off-by: Guanghui Feng <guanghuifeng@linux.alibaba.com>
> > Reviewed-by: Guixin Liu <kanie@linux.alibaba.com>
> 
> Can you please supply the lspci information Lukas requested here?
> https://lore.kernel.org/r/aS1oArFHeo9FAuv-@wunner.de
> 
> Also, if there is language in the PCIe spec you can cite here about
> the need to independently wait for each device, that would be useful.
> 
> Bjorn

  reply	other threads:[~2025-12-02 16:51 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-24 10:45 [PATCH] PCI: Fix PCIe SBR dev/link wait error Guanghui Feng
2025-11-24 23:58 ` Bjorn Helgaas
2025-11-25  6:20   ` guanghui.fgh
2025-12-01 10:03     ` Lukas Wunner
2025-12-01 12:56       ` guanghuifeng
2025-12-01 13:26         ` Lukas Wunner
2025-12-01 14:46           ` guanghuifeng
2025-12-01 16:18             ` Lukas Wunner
2025-11-26  8:20 ` Ilpo Järvinen
2025-11-26 12:08   ` guanghui.fgh
2025-11-26 12:37     ` Ilpo Järvinen
2025-11-26 14:22       ` guanghui.fgh
2025-11-26 14:47         ` Ilpo Järvinen
2025-11-29 16:36           ` [PATCH v2] " Guanghui Feng
2025-12-01  9:21             ` Ilpo Järvinen
2025-12-01 12:21               ` guanghuifeng
2025-12-01 13:08                 ` Ilpo Järvinen
2025-12-02  4:32                   ` [PATCH v4 0/1] " Guanghui Feng
2025-12-02  4:32                     ` [PATCH v4 v4 1/1] " Guanghui Feng
2025-12-02 16:49                       ` Bjorn Helgaas
2025-12-02 16:51                         ` Bjorn Helgaas [this message]
2025-12-03 14:41                       ` Ilpo Järvinen
2025-11-30  5:17           ` [PATCH v3] " Guanghui Feng
2025-12-01  9:24             ` Ilpo Järvinen
2025-12-01 12:31               ` guanghuifeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251202165149.GA3077343@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=alikernel-developer@linux.alibaba.com \
    --cc=bhelgaas@google.com \
    --cc=guanghuifeng@linux.alibaba.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.