From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79FB736920B; Wed, 3 Dec 2025 16:57:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764781056; cv=none; b=GLnhIOstjR/Q6b2KcSuer9rv7W9Ru35nsYfQR2NYewqQOnjrU2SI1W6EGPFnMocWwsRN2EQIBkyOI8RUZYhUjOqfVWWQWyPBDySeVC3gunTOhZ08LHjrFq5VRIakSHLpwDmVK19j/fOsP7Ly1gGpPzyiu4eKEpsoMwbmtNtzzfU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764781056; c=relaxed/simple; bh=CDmeRn3rQ9Y1QcCU1VtVc5k/I4dyFPIvchOBq/cTUiQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=be3uTaGic4pEwWyzOc877YGRo0+2A39/VcPChjmsn/5lqWWPmgTKE4T7f9T2BNhCovpPokoxzG+vFN3zeTOurGr9sWzk1ZGtgoIBrgNtQZbMhILpkb4DNlHuDJIt5hkFKoLisdY0hkmTHcJ7JNmdN4aCzMf7pyWb82iIS8/8gN0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VbKl3Hl1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VbKl3Hl1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9F4CC4CEF5; Wed, 3 Dec 2025 16:57:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1764781056; bh=CDmeRn3rQ9Y1QcCU1VtVc5k/I4dyFPIvchOBq/cTUiQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VbKl3Hl1FZovcPkR1UN1GkFmog3/KjlvCQb163Kck5OHNHhepgnmyQSQb4v3iFxrz 4+E+Hb/1z9PRaBpnofuo5znMjjYtDiJmts8suXxvWMAPhHRgsFuWkawQF3nh8v7DAW +ZSlD9uvEFRmepUOvb6S6p0pO6Io0ZsYsdd6S9Pg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Christophe JAILLET , =?UTF-8?q?Nuno=20S=C3=A1?= , Stable@vger.kernel.org, Jonathan Cameron Subject: [PATCH 6.6 36/93] iio:common:ssp_sensors: Fix an error handling path ssp_probe() Date: Wed, 3 Dec 2025 16:29:29 +0100 Message-ID: <20251203152337.850919927@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251203152336.494201426@linuxfoundation.org> References: <20251203152336.494201426@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Christophe JAILLET commit 21553258b94861a73d7f2cf15469d69240e1170d upstream. If an error occurs after a successful mfd_add_devices() call, it should be undone by a corresponding mfd_remove_devices() call, as already done in the remove function. Fixes: 50dd64d57eee ("iio: common: ssp_sensors: Add sensorhub driver") Signed-off-by: Christophe JAILLET Reviewed-by: Nuno Sá Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/common/ssp_sensors/ssp_dev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/iio/common/ssp_sensors/ssp_dev.c +++ b/drivers/iio/common/ssp_sensors/ssp_dev.c @@ -503,7 +503,7 @@ static int ssp_probe(struct spi_device * ret = spi_setup(spi); if (ret < 0) { dev_err(&spi->dev, "Failed to setup spi\n"); - return ret; + goto err_setup_spi; } data->fw_dl_state = SSP_FW_DL_STATE_NONE; @@ -568,6 +568,8 @@ err_read_reg: err_setup_irq: mutex_destroy(&data->pending_lock); mutex_destroy(&data->comm_lock); +err_setup_spi: + mfd_remove_devices(&spi->dev); dev_err(&spi->dev, "Probe failed!\n");