From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AC8326CE17; Wed, 3 Dec 2025 16:52:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764780728; cv=none; b=U6GwAhEozabfXs/lmyicuqtonZGMk84Fi4cgG5oCEZLgCUR1M0Q8VTTuGB6MDe19J2DsrboAq2GVdEKNmj4/37YL3ukzmJG4Nl6A1WEZXUFp6CllP+SYJ7bmLIg0qePlK7zT9LuhZ/14gyOEwkGq8Em3C7lgjzenTMoo+sdQ77s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764780728; c=relaxed/simple; bh=ymJvcqpFCPjiVyCEkCqta2jLvySRIhr3qxHjdn3R2Bw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RLLQ8YqCDGS9c4IvgKOQoWgJzkKFrdacY55Z7KUmQ763wxKeXC2poX5IKkBMUeTaoaoZFdkLG7NHVwDCCrx3CC3hTwXEtpAG73FmBcqe9Dil0cl5zdofSGLG4nKkHbw0EiRCIXSMcx5BJ+j/qQYxtaucq9ecW6s65wtDRlPZVqg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=DUOmQ9Oz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="DUOmQ9Oz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 174E0C116B1; Wed, 3 Dec 2025 16:52:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1764780728; bh=ymJvcqpFCPjiVyCEkCqta2jLvySRIhr3qxHjdn3R2Bw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DUOmQ9Ozc7WCUhGtX95AXQlJyHoQtax7P0NUjh6VD2SfHt7BSBDdooiLg1y1ds2Sc I0M9DzpOrUsX+Pf4zCs9f2IzOGv5MiwtGsdXryBhEyVTxa84kpj0XkpgzRiCsS1vgR sd1KNmc5ZKCk7ee1Eee7E5O6TVCsGfjD/kXi1lNM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Thomas=20M=C3=BChlbacher?= , Jernej Skrabec , Marc Kleine-Budde Subject: [PATCH 6.12 073/132] can: sun4i_can: sun4i_can_interrupt(): fix max irq loop handling Date: Wed, 3 Dec 2025 16:29:12 +0100 Message-ID: <20251203152345.998890344@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251203152343.285859633@linuxfoundation.org> References: <20251203152343.285859633@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Marc Kleine-Budde commit 76544beea7cfe5bcce6d60f53811657b88ec8be1 upstream. Reading the interrupt register `SUN4I_REG_INT_ADDR` causes all of its bits to be reset. If we ever reach the condition of handling more than `SUN4I_CAN_MAX_IRQ` IRQs, we will have read the register and reset all its bits but without actually handling the interrupt inside of the loop body. This may, among other issues, cause us to never `netif_wake_queue()` again after a transmission interrupt. Fixes: 0738eff14d81 ("can: Allwinner A10/A20 CAN Controller support - Kernel module") Cc: stable@vger.kernel.org Co-developed-by: Thomas Mühlbacher Signed-off-by: Thomas Mühlbacher Acked-by: Jernej Skrabec Link: https://patch.msgid.link/20251116-sun4i-fix-loop-v1-1-3d76d3f81950@pengutronix.de Signed-off-by: Marc Kleine-Budde Signed-off-by: Greg Kroah-Hartman --- drivers/net/can/sun4i_can.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/net/can/sun4i_can.c +++ b/drivers/net/can/sun4i_can.c @@ -657,8 +657,8 @@ static irqreturn_t sun4i_can_interrupt(i u8 isrc, status; int n = 0; - while ((isrc = readl(priv->base + SUN4I_REG_INT_ADDR)) && - (n < SUN4I_CAN_MAX_IRQ)) { + while ((n < SUN4I_CAN_MAX_IRQ) && + (isrc = readl(priv->base + SUN4I_REG_INT_ADDR))) { n++; status = readl(priv->base + SUN4I_REG_STA_ADDR);