From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AECF2FD678; Wed, 3 Dec 2025 15:34:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764776077; cv=none; b=m6wrP87oTZ8k+NKNjKeDRC6svoq3mNa7g5dT0afCbqJPlEsLmH85JeV4EU4x1bv+Di/FSukSEwQkeqHoTTRXUNUTAehLHrW+qYGRJeUIwMFtJKwCA6Kz7ymmU0QXryCBCslvTGqHq9v6gY2TduHrv8bPjIQ2TGktElwTTe2ABxs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764776077; c=relaxed/simple; bh=ks/mU3e/sxn6lGTrXUgOOqYwwt1r9pPNfGl2fMIUdco=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iQsDfbxwRALHCuY6PvF/6FVAkPACQj6nFscZSL2dUTRpo9K9GaJBFxhAlnqJwYWwWVGQALvdTaETeRLNpQu5f0jU1RoLoJjaSUeS45O6G6P3xUkJ4DWQlX6PYqK2QyqnPaYzJgpFMTeyv1b2G5naqUnxKejRAmrEJ2Cs0TqhPXM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=S9QsKRhC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="S9QsKRhC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A990C4CEF5; Wed, 3 Dec 2025 15:34:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1764776076; bh=ks/mU3e/sxn6lGTrXUgOOqYwwt1r9pPNfGl2fMIUdco=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S9QsKRhCOQiaocf37SCA7ImYG4XStdw8WbUEMmN5iRCCIFlckPUmp304VpF0Q8y1Z I0oMUj4+53iOMxoQ19+WcQ3VgZMzd88yEuyT9HDNotNW4lHiAkXzQESmuFvAB694WP b+5nr/tPoJdSDxvY4cRG05sCIYeODleo6EFS2ocM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Geoffrey McRae , Alex Deucher , Felix Kuehling , Sasha Levin Subject: [PATCH 5.10 074/300] drm/amdkfd: return -ENOTTY for unsupported IOCTLs Date: Wed, 3 Dec 2025 16:24:38 +0100 Message-ID: <20251203152403.364234118@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251203152400.447697997@linuxfoundation.org> References: <20251203152400.447697997@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Geoffrey McRae [ Upstream commit 57af162bfc8c05332a28c4d458d246cc46d2746d ] Some kfd ioctls may not be available depending on the kernel version the user is running, as such we need to report -ENOTTY so userland can determine the cause of the ioctl failure. Signed-off-by: Geoffrey McRae Acked-by: Alex Deucher Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c index 869c8786df5c9..04367ae4b425d 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c @@ -1887,8 +1887,10 @@ static long kfd_ioctl(struct file *filep, unsigned int cmd, unsigned long arg) unsigned int usize, asize; int retcode = -EINVAL; - if (nr >= AMDKFD_CORE_IOCTL_COUNT) + if (nr >= AMDKFD_CORE_IOCTL_COUNT) { + retcode = -ENOTTY; goto err_i1; + } if ((nr >= AMDKFD_COMMAND_START) && (nr < AMDKFD_COMMAND_END)) { u32 amdkfd_size; @@ -1901,8 +1903,10 @@ static long kfd_ioctl(struct file *filep, unsigned int cmd, unsigned long arg) asize = amdkfd_size; cmd = ioctl->cmd; - } else + } else { + retcode = -ENOTTY; goto err_i1; + } dev_dbg(kfd_device, "ioctl cmd 0x%x (#0x%x), arg 0x%lx\n", cmd, nr, arg); -- 2.51.0