From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 114653093DF; Wed, 3 Dec 2025 15:36:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764776206; cv=none; b=kOUwXkGrK3Ln9/XAQ2ynJzN/klA6JN+nns0vLusqYgsF9DyNEBpKt6mztQvTFioKpHcUwr+YE44FbRK3pjwM/3CWPEwH4gB1rLIDozduAA/pJEiS87V2MAaf26zUPz+a4FnLlImZBRSK/CBT36cyyVqRvZ+0GhCS3od3gwdw38Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764776206; c=relaxed/simple; bh=DxJAxVoG9c11FCqunaY1OqBT98JPbn18sJdTc3t0aZI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Z7quT5jFF1GIByuhjChDkiPEPPd8Wo9joRzAAqwbqARyK/sZWo8qgK0etL8n8sj03OMQpKyhbbK1fZSiOQPBwZZ+csbYsAzYbd/JHnsf9bDNdV3OSs0AUAyBSzP/VojTJgFwq/4Uv8RL4C1egk1gehqYVyDRcoy7FUHR0SzXq0w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Wy4XaQND; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Wy4XaQND" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74258C4CEF5; Wed, 3 Dec 2025 15:36:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1764776205; bh=DxJAxVoG9c11FCqunaY1OqBT98JPbn18sJdTc3t0aZI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Wy4XaQNDTfW+ajmoFkkLpRcq5Z28Ucio1KBWUXQlHM6CZPHkzFa8TagEmodtru5Il 3z8QFI/E4XvUayZ6yX+CikPsJWm7TMLu40wjDNolsyg2k5BXUSGSwKueYld4ptOs7f 72bDWnvQCavgyCBe4H4dBqb0GYmdwV1thcgX1y7Q= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Petr Machata , David Ahern , Ido Schimmel , Paolo Abeni , Sasha Levin Subject: [PATCH 5.10 113/300] selftests: traceroute: Use require_command() Date: Wed, 3 Dec 2025 16:25:17 +0100 Message-ID: <20251203152404.807048007@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251203152400.447697997@linuxfoundation.org> References: <20251203152400.447697997@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ido Schimmel [ Upstream commit 47efbac9b768553331b9459743a29861e0acd797 ] Use require_command() so that the test will return SKIP (4) when a required command is not present. Before: # ./traceroute.sh SKIP: Could not run IPV6 test without traceroute6 SKIP: Could not run IPV4 test without traceroute $ echo $? 0 After: # ./traceroute.sh TEST: traceroute6 not installed [SKIP] $ echo $? 4 Reviewed-by: Petr Machata Reviewed-by: David Ahern Signed-off-by: Ido Schimmel Link: https://patch.msgid.link/20250908073238.119240-6-idosch@nvidia.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- tools/testing/selftests/net/traceroute.sh | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/tools/testing/selftests/net/traceroute.sh b/tools/testing/selftests/net/traceroute.sh index de9ca97abc306..9cb5e96e64333 100755 --- a/tools/testing/selftests/net/traceroute.sh +++ b/tools/testing/selftests/net/traceroute.sh @@ -209,11 +209,6 @@ setup_traceroute6() run_traceroute6() { - if [ ! -x "$(command -v traceroute6)" ]; then - echo "SKIP: Could not run IPV6 test without traceroute6" - return - fi - setup_traceroute6 # traceroute6 host-2 from host-1 (expects 2000:102::2) @@ -278,11 +273,6 @@ setup_traceroute() run_traceroute() { - if [ ! -x "$(command -v traceroute)" ]; then - echo "SKIP: Could not run IPV4 test without traceroute" - return - fi - setup_traceroute # traceroute host-2 from host-1 (expects 1.0.1.1). Takes a while. @@ -316,6 +306,9 @@ do esac done +require_command traceroute6 +require_command traceroute + run_tests printf "\nTests passed: %3d\n" ${nsuccess} -- 2.51.0