From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE99931326B; Wed, 3 Dec 2025 15:45:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764776737; cv=none; b=axCmhQnc2aqTsUBwsZhlMV+ocYpNnb0J/2IXLFzxf8dOu7nRsOAEnRlBBy5JyqPJLt24iJB4fIasMoAstlMEMMjaExUxOODABHjxUtVdHWJOfW2Vt/rP15JbnbnFqmiNbKQ4Q6Y6X3h0UGJArk0OtZWei8FTngNqQPCcynkf8v4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764776737; c=relaxed/simple; bh=uWCjLRdP9a0Nn0KI8UnBGqxHUbleALFOJloPhtzvTMg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=txssYVOu7R+eZPeFJZ67j7v0qs9hI2TSEYvbGs/PqlDl/0bGcRMBPMM4IpM8Au7Faw+hYyM0HBIx1M1VupXjoPJO1Rhurm5NGa/Y5RZD2RnBxgHWOBdfb5iujw+B5VVPFcvf2NuOv5rppnYBJlgaoEhOv0tINPrSrowz1WarbqU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=d2GP7rui; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="d2GP7rui" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39DC7C4CEF5; Wed, 3 Dec 2025 15:45:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1764776737; bh=uWCjLRdP9a0Nn0KI8UnBGqxHUbleALFOJloPhtzvTMg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d2GP7rui13U4XI1B8JQ2rZBFFIpoS3yLevkqH+/L7a1wGyPcyFfN3vMrhaOpDFrvm TngvOVa0EHIEZiGtKtuzqVXJMwwifhaKBM3Qq5B2+gFdmuMei+G/d40ayAQ7Z/GrgU 7mY2iMmX9zCROtG1+MHlas+UwbWfdR6jYWnSoqzo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Thomas=20M=C3=BChlbacher?= , Jernej Skrabec , Marc Kleine-Budde Subject: [PATCH 5.10 271/300] can: sun4i_can: sun4i_can_interrupt(): fix max irq loop handling Date: Wed, 3 Dec 2025 16:27:55 +0100 Message-ID: <20251203152410.673171765@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251203152400.447697997@linuxfoundation.org> References: <20251203152400.447697997@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Marc Kleine-Budde commit 76544beea7cfe5bcce6d60f53811657b88ec8be1 upstream. Reading the interrupt register `SUN4I_REG_INT_ADDR` causes all of its bits to be reset. If we ever reach the condition of handling more than `SUN4I_CAN_MAX_IRQ` IRQs, we will have read the register and reset all its bits but without actually handling the interrupt inside of the loop body. This may, among other issues, cause us to never `netif_wake_queue()` again after a transmission interrupt. Fixes: 0738eff14d81 ("can: Allwinner A10/A20 CAN Controller support - Kernel module") Cc: stable@vger.kernel.org Co-developed-by: Thomas Mühlbacher Signed-off-by: Thomas Mühlbacher Acked-by: Jernej Skrabec Link: https://patch.msgid.link/20251116-sun4i-fix-loop-v1-1-3d76d3f81950@pengutronix.de Signed-off-by: Marc Kleine-Budde Signed-off-by: Greg Kroah-Hartman --- drivers/net/can/sun4i_can.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/net/can/sun4i_can.c +++ b/drivers/net/can/sun4i_can.c @@ -644,8 +644,8 @@ static irqreturn_t sun4i_can_interrupt(i u8 isrc, status; int n = 0; - while ((isrc = readl(priv->base + SUN4I_REG_INT_ADDR)) && - (n < SUN4I_CAN_MAX_IRQ)) { + while ((n < SUN4I_CAN_MAX_IRQ) && + (isrc = readl(priv->base + SUN4I_REG_INT_ADDR))) { n++; status = readl(priv->base + SUN4I_REG_STA_ADDR);