From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38FBD3093DF; Wed, 3 Dec 2025 15:47:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764776857; cv=none; b=R9bmfGct/hdQNoQBNQPxIrcgOJOaXU+0F2XEqgpZos0NrjPBi66fPz3+sgyw9XZ6o2P7hW0hyDJj/9fdDIXkxA9uTkMkrUlGuaewAsc/HJ10A+5Ft5JDTfPCEJhr/CO8ZXyCKuJ2ZRCsmz7hADUSxu7j11qqQEViPPdmoU4m5eI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764776857; c=relaxed/simple; bh=0NWBXo7d5Fl0i/+a2R/7TkAXmqdUXM8MEF9P+cl/Vpk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Slv5AFVvwhNWPfkxV3kgHDQryS2kghBdDcnaVt7TcIcgzPX1ORnbGIRsL3BU/iWL+nuDuIJr6O3xVkiyZplcrUHTJ2NJmruW3z8iTWRVZDpOuxKUA4UJdJgMWjHqffzzoK/tO6RikFA/k5oc1Ee87XPBApdPTM03xHTxtfvDBRM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bqXh5PtB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bqXh5PtB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4650C4CEF5; Wed, 3 Dec 2025 15:47:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1764776857; bh=0NWBXo7d5Fl0i/+a2R/7TkAXmqdUXM8MEF9P+cl/Vpk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bqXh5PtBfJRQ1L1nbVEend2ynBfWhSqcGhbTRU0oVBXiML5TR1VXF0jeAYovspHuO KOJSQNumfbzwAUdUP/oo164XFQHZCs2FvL0A8wOyQs/LgKyw1SLWrdrkchQmmLJWah f5jgfFirZ7AXrs2fu6sDwEi2NgXC3J/rNt4aEARE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Miaoqian Lin , Dmitry Baryshkov Subject: [PATCH 5.10 274/300] slimbus: ngd: Fix reference count leak in qcom_slim_ngd_notify_slaves Date: Wed, 3 Dec 2025 16:27:58 +0100 Message-ID: <20251203152410.781185613@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251203152400.447697997@linuxfoundation.org> References: <20251203152400.447697997@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Miaoqian Lin commit 96cf8500934e0ce2a6c486f1dbc3b1fff12f7a5e upstream. The function qcom_slim_ngd_notify_slaves() calls of_slim_get_device() which internally uses device_find_child() to obtain a device reference. According to the device_find_child() documentation, the caller must drop the reference with put_device() after use. Found via static analysis and this is similar to commit 4e65bda8273c ("ASoC: wcd934x: fix error handling in wcd934x_codec_parse_data()") Fixes: 917809e2280b ("slimbus: ngd: Add qcom SLIMBus NGD driver") Cc: stable Signed-off-by: Miaoqian Lin Reviewed-by: Dmitry Baryshkov Link: https://patch.msgid.link/20251027060601.33228-1-linmq006@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Greg Kroah-Hartman --- drivers/slimbus/qcom-ngd-ctrl.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -1149,6 +1149,7 @@ static void qcom_slim_ngd_notify_slaves( if (slim_get_logical_addr(sbdev)) dev_err(ctrl->dev, "Failed to get logical address\n"); + put_device(&sbdev->dev); } }