From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23480313546; Wed, 3 Dec 2025 16:07:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764778064; cv=none; b=GB9YDFRhcx4ry2P9meE9TIMDwjdAg4s2ghMW4W3139ORo99ydCSCUFUPvdA6Vps2097rrg5CxAqd1ZMTbCvW7jGxgQywy1cx0OpL0OyP92iplnrx9Sci95KQH3qJIivinGsDpXMMz81UwkFBiKsZgzEsO2Phw8WU70fVT9WQT3M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764778064; c=relaxed/simple; bh=md7O2iDK5uqo0/EMO+bRcghytxMk01PGg8LU27gsBJE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g5kuFnKtFt3ebMRM+EGPIWHqryYOH5a0kgww3E8MVLIiD+es1AIL+E9aday0KId0IvjsSg9PTpKojT+iya81JcKk6FHtmDYpMJRrWnnrRLK+l2KAd0zY39CciFAoUan4G5klseCkV2eFyQuISxapGtVzg3xXX52+b3FMgV8byuQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Vv0ouKRs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Vv0ouKRs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C878C4CEF5; Wed, 3 Dec 2025 16:07:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1764778064; bh=md7O2iDK5uqo0/EMO+bRcghytxMk01PGg8LU27gsBJE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Vv0ouKRs9vgtN4zhfB4TExWr3T8BbhhXMjckhklHy89xQiym+DD/++UetFJ5Agefl Z1NJsd4UD8ACuX4qayUR7NrrPgPoYFi0z2XotuQCWv4WARPwKASIJyryUBOcYrhnQC jvKG13z+zMOwTxHFmRiE5zbupKuZ+VrwCgGrNXwY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Viacheslav Dubeyko , Alex Markuze , Ilya Dryomov , Sasha Levin Subject: [PATCH 5.15 205/392] ceph: add checking of wait_for_completion_killable() return value Date: Wed, 3 Dec 2025 16:25:55 +0100 Message-ID: <20251203152421.617954270@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251203152414.082328008@linuxfoundation.org> References: <20251203152414.082328008@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Viacheslav Dubeyko [ Upstream commit b7ed1e29cfe773d648ca09895b92856bd3a2092d ] The Coverity Scan service has detected the calling of wait_for_completion_killable() without checking the return value in ceph_lock_wait_for_completion() [1]. The CID 1636232 defect contains explanation: "If the function returns an error value, the error value may be mistaken for a normal value. In ceph_lock_wait_for_completion(): Value returned from a function is not checked for errors before being used. (CWE-252)". The patch adds the checking of wait_for_completion_killable() return value and return the error code from ceph_lock_wait_for_completion(). [1] https://scan5.scan.coverity.com/#/project-view/64304/10063?selectedIssue=1636232 Signed-off-by: Viacheslav Dubeyko Reviewed-by: Alex Markuze Signed-off-by: Ilya Dryomov Signed-off-by: Sasha Levin --- fs/ceph/locks.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/ceph/locks.c b/fs/ceph/locks.c index 3e3b8be76b21e..38974c54240d6 100644 --- a/fs/ceph/locks.c +++ b/fs/ceph/locks.c @@ -202,7 +202,10 @@ static int ceph_lock_wait_for_completion(struct ceph_mds_client *mdsc, if (err && err != -ERESTARTSYS) return err; - wait_for_completion_killable(&req->r_safe_completion); + err = wait_for_completion_killable(&req->r_safe_completion); + if (err) + return err; + return 0; } -- 2.51.0