From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 965682FB0B4; Wed, 3 Dec 2025 16:07:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764778045; cv=none; b=Ucxn5xqCF1GdMbyD/EQQRFY57ju7n9905HTmdeXDgNqSsHgX30wmtfev84eqnOmdlSSQdsTMrgej0YottK+pwl2JCUZkFNVJY3Y4+Dn/6SbQUEy1xx+9h7hgAbXrpPcdm32oNPW5kD98LwZ81KtSl/H66KoHLFLDQPlsRu8qItE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764778045; c=relaxed/simple; bh=6xQZERcSWnzJDyn5IQqBUOvLTdmdBJgz6+Stylh5zEg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qfqJ0L8mKuCfT84Se4hUn5J0DHhFvayCYBrzdroVpQerlsVHar1MyE9IVHu/N/lp7of2s6OQeqwDEI58906PQ+byzab8VXlrQsytPvuO91k82HwmSQAvAUi+SQ91ZS3MrR6sgDRnE89Aziy5OgO+L2T5uGjSnpCsgqhtJXooxFw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ezWFtJnr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ezWFtJnr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05310C4CEF5; Wed, 3 Dec 2025 16:07:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1764778045; bh=6xQZERcSWnzJDyn5IQqBUOvLTdmdBJgz6+Stylh5zEg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ezWFtJnr14vWsVhV5J7ACcKKhc/egMahcO49lz8Rq5OOQfvQWH4acQLm/65VSaNQh 8KsjUfbNYyWIP7wbiaexjI7MiTOEHxaW3PcLEkE1tt/pm3qxxNDidNQXqcvZMHC87Z BCoO8AmtpgUGG2BlE8m3LoE+lLpeuST+7Jq+9AZk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yuta Hayama , Alexandre Belloni Subject: [PATCH 5.15 226/392] rtc: rx8025: fix incorrect register reference Date: Wed, 3 Dec 2025 16:26:16 +0100 Message-ID: <20251203152422.500240321@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251203152414.082328008@linuxfoundation.org> References: <20251203152414.082328008@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yuta Hayama commit 162f24cbb0f6ec596e7e9f3e91610d79dc805229 upstream. This code is intended to operate on the CTRL1 register, but ctrl[1] is actually CTRL2. Correctly, ctrl[0] is CTRL1. Signed-off-by: Yuta Hayama Fixes: 71af91565052 ("rtc: rx8025: fix 12/24 hour mode detection on RX-8035") Cc: stable@vger.kernel.org Link: https://patch.msgid.link/eae5f479-5d28-4a37-859d-d54794e7628c@lineo.co.jp Signed-off-by: Alexandre Belloni Signed-off-by: Greg Kroah-Hartman --- drivers/rtc/rtc-rx8025.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/rtc/rtc-rx8025.c +++ b/drivers/rtc/rtc-rx8025.c @@ -318,7 +318,7 @@ static int rx8025_init_client(struct i2c return hour_reg; rx8025->is_24 = (hour_reg & RX8035_BIT_HOUR_1224); } else { - rx8025->is_24 = (ctrl[1] & RX8025_BIT_CTRL1_1224); + rx8025->is_24 = (ctrl[0] & RX8025_BIT_CTRL1_1224); } out: return err;