From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78188346FC8; Wed, 3 Dec 2025 16:12:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764778321; cv=none; b=BRfAYYvWKgxveSKM6r3iadXgcfZDjTYV4E8U+MKvfqdsNlpLexZTPxZc4Gl0u7Yj1aoJSPk7eiMUblN20pQ8dBmw3t/FcO5BViNLKaRYVmDtZMaF4g7unT/tKPS03OEmMHCnHLHYxutgkCA/KXre0ZZYglbrdJ2fUvX8nwAIs4U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764778321; c=relaxed/simple; bh=xiw+mDpvVTlx4y7XmT2i+/M9Um7ikQt9X3BGj6TyyZs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=f7GTMDgj+/l0kCpPgh/2yxl7pDi1H2lUITYvkQcReKawqeDgMs0IghhsVgj2kLVADEy71E5KAHSIceX0oINYktdgjugf2cbrGi1p18uOwBjfAUhu+dPNJ4w+GZ1GmPqsHZgu85BPVPp/KOUzLIPEnS4kecu769Iv1T0p58/BXgM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ULDuH1ic; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ULDuH1ic" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5602C4CEF5; Wed, 3 Dec 2025 16:12:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1764778321; bh=xiw+mDpvVTlx4y7XmT2i+/M9Um7ikQt9X3BGj6TyyZs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ULDuH1iciasril9mWUYiKKvRjwwNOrRx4wJIdaaejDnRTbX96E/vLPZzFSR7TVKSz RwndTVm1WT9LeuBckBWMUcc1uh3jAcbSEK2WN7DJtPZqhR/PFAUy5V3rcj74n2M5ff KJgk2mxRHRnUoHT9+TPkhn9en6f+AAodFa80L2Ss= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Hans de Goede , Mark Brown Subject: [PATCH 5.15 277/392] spi: Try to get ACPI GPIO IRQ earlier Date: Wed, 3 Dec 2025 16:27:07 +0100 Message-ID: <20251203152424.356157705@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251203152414.082328008@linuxfoundation.org> References: <20251203152414.082328008@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hans de Goede commit 3cd2018e15b3d66d2187d92867e265f45ad79e6f upstream. Since commit d24cfee7f63d ("spi: Fix acpi deferred irq probe"), the acpi_dev_gpio_irq_get() call gets delayed till spi_probe() is called on the SPI device. If there is no driver for the SPI device then the move to spi_probe() results in acpi_dev_gpio_irq_get() never getting called. This may cause problems by leaving the GPIO pin floating because this call is responsible for setting up the GPIO pin direction and/or bias according to the values from the ACPI tables. Re-add the removed acpi_dev_gpio_irq_get() in acpi_register_spi_device() to ensure the GPIO pin is always correctly setup, while keeping the acpi_dev_gpio_irq_get() call added to spi_probe() to deal with -EPROBE_DEFER returns caused by the GPIO controller not having a driver yet. Link: https://bbs.archlinux.org/viewtopic.php?id=302348 Fixes: d24cfee7f63d ("spi: Fix acpi deferred irq probe") Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede Link: https://patch.msgid.link/20251102190921.30068-1-hansg@kernel.org Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- drivers/spi/spi.c | 10 ++++++++++ 1 file changed, 10 insertions(+) --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -2416,6 +2416,16 @@ static acpi_status acpi_register_spi_dev acpi_set_modalias(adev, acpi_device_hid(adev), spi->modalias, sizeof(spi->modalias)); + /* + * This gets re-tried in spi_probe() for -EPROBE_DEFER handling in case + * the GPIO controller does not have a driver yet. This needs to be done + * here too, because this call sets the GPIO direction and/or bias. + * Setting these needs to be done even if there is no driver, in which + * case spi_probe() will never get called. + */ + if (spi->irq < 0) + spi->irq = acpi_dev_gpio_irq_get(adev, 0); + acpi_device_set_enumerated(adev); adev->power.flags.ignore_parent = true;