From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 504C93469EF; Wed, 3 Dec 2025 16:11:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764778302; cv=none; b=TdfoXfgqV2hxwaTzny+41xT56YUE+j/TYtC8qHxRKtvJxPurXEQfsiI8hbPwKrk7ZnPwQQ74xfjhTmgHb6gtyfA/4Qjl3VLlQhAzJXqhbpGX323FXVVFl8okxZ7XqD3fQ4a6dTQ6YzWa8R6pAmbxCJWwZf9Pi/P1HHr5600i/Gw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764778302; c=relaxed/simple; bh=K/rQe8sZgQDRZgTfz4gdyBhsRnCRiemLV8W1oPnUNCE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=I0g6hjLgs3/Y/pOZJwuqIwLH1/0gr+hkL/e/oSNgXYIgeCesHan6UvKSV+HortHRzQKWibIoQUouIHj6N8qEjbwvEjTy9SLj1jXUGg+JGcnRz7oz4IF9w6S3tGyHUPtZz71dXMFTOM0j+lELYzauhQwbLQoAOnJodcejcXVIArU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1GK2hGEZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1GK2hGEZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC135C4CEF5; Wed, 3 Dec 2025 16:11:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1764778302; bh=K/rQe8sZgQDRZgTfz4gdyBhsRnCRiemLV8W1oPnUNCE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1GK2hGEZpkWsLBRc0oxDZ3rVE0HNqVCOyhYstxYcTELEFbb8m6FrHEB9KuRYZ8dIS hKZXE/3VJH7ktIolQWl+bPrgd9XdHD41QTunvWPkIZW1M9uBwIr6pfOmz4pRNDj0as uUSN7WxWbG3bvlkPEGW9dwCtVDMQwBZ2J63zx+20= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Edoardo Canepa , Po-Hsu Lin , Przemek Kitszel , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.15 303/392] selftests: net: use BASH for bareudp testing Date: Wed, 3 Dec 2025 16:27:33 +0100 Message-ID: <20251203152425.315943367@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251203152414.082328008@linuxfoundation.org> References: <20251203152414.082328008@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Po-Hsu Lin [ Upstream commit 9311e9540a8b406d9f028aa87fb072a3819d4c82 ] In bareudp.sh, this script uses /bin/sh and it will load another lib.sh BASH script at the very beginning. But on some operating systems like Ubuntu, /bin/sh is actually pointed to DASH, thus it will try to run BASH commands with DASH and consequently leads to syntax issues: # ./bareudp.sh: 4: ./lib.sh: Bad substitution # ./bareudp.sh: 5: ./lib.sh: source: not found # ./bareudp.sh: 24: ./lib.sh: Syntax error: "(" unexpected Fix this by explicitly using BASH for bareudp.sh. This fixes test execution failures on systems where /bin/sh is not BASH. Reported-by: Edoardo Canepa Link: https://bugs.launchpad.net/bugs/2129812 Signed-off-by: Po-Hsu Lin Reviewed-by: Przemek Kitszel Link: https://patch.msgid.link/20251027095710.2036108-2-po-hsu.lin@canonical.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- tools/testing/selftests/net/bareudp.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/bareudp.sh b/tools/testing/selftests/net/bareudp.sh index f366cadbc5e86..ff4308b48e65d 100755 --- a/tools/testing/selftests/net/bareudp.sh +++ b/tools/testing/selftests/net/bareudp.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/bash # SPDX-License-Identifier: GPL-2.0 # Test various bareudp tunnel configurations. -- 2.51.0