From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECC693491FB; Wed, 3 Dec 2025 16:12:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764778355; cv=none; b=QTW9szxptQhyI+GPGJAe9LPp9XXBa2EH0RhXSMESxQ2BirrrD2aFcgFGSchJGnBM80TEM0VjGvpLY+p8T8Ig1Z9qVp/UgV+0hoSYBwtOOuLF/v+kxflGsm+3X77iR7yAPiUAmCQJd7JbGsAkmIEYLR+X/pRrztML1ejr+LHB20M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764778355; c=relaxed/simple; bh=Wa3H/lX00PDoZ67mO8R4xsPFYo6OL/varNscE634VVo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bONUCD3YVwEemXYfbFH/Z2KAxCOxNcV46t6Ca1VFUVV4kytMK5iFyGrCbHBixe93s9ZH/u8s30in2O4xHinWIJiW2s4jrTrkiN6RDHggTl9y8937JpfroXDBL3b/2p+vACFHLyLz1YxzqF2ydrSQ2NFmwklXz+jXyT2F1ovAecA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Ouu/ktO9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Ouu/ktO9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D1C0C4CEF5; Wed, 3 Dec 2025 16:12:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1764778354; bh=Wa3H/lX00PDoZ67mO8R4xsPFYo6OL/varNscE634VVo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ouu/ktO9cHKFUAnp95iyvsFJp7z42u7NhoixqkoPCKGsmCSKDR6JLhBFNOScytRVj halPYTXqZnbuStL5vonypUj36vVPZVDHgOHuxCT9FLq3ioIzZvpH/CAuGlIo9F3inM M5mhQVjNKriGRDDwegLBbrY4zIgtEO4CI9P6If+s= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Peter Griffin , Krzysztof Kozlowski , =?UTF-8?q?Andr=C3=A9=20Draszik?= , Marek Szyprowski , Ulf Hansson , Sasha Levin Subject: [PATCH 5.15 321/392] pmdomain: samsung: plug potential memleak during probe Date: Wed, 3 Dec 2025 16:27:51 +0100 Message-ID: <20251203152425.973580773@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251203152414.082328008@linuxfoundation.org> References: <20251203152414.082328008@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: André Draszik [ Upstream commit 90c82941adf1986364e0f82c35cf59f2bf5f6a1d ] of_genpd_add_provider_simple() could fail, in which case this code leaks the domain name, pd->pd.name. Use devm_kstrdup_const() to plug this leak. As a side-effect, we can simplify existing error handling. Fixes: c09a3e6c97f0 ("soc: samsung: pm_domains: Convert to regular platform driver") Cc: stable@vger.kernel.org Reviewed-by: Peter Griffin Reviewed-by: Krzysztof Kozlowski Signed-off-by: André Draszik Tested-by: Marek Szyprowski Signed-off-by: Ulf Hansson [ drivers/pmdomain/samsung/exynos-pm-domains.c -> drivers/soc/samsung/pm_domains.c ] Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/soc/samsung/pm_domains.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) --- a/drivers/soc/samsung/pm_domains.c +++ b/drivers/soc/samsung/pm_domains.c @@ -92,13 +92,14 @@ static const struct of_device_id exynos_ { }, }; -static const char *exynos_get_domain_name(struct device_node *node) +static const char *exynos_get_domain_name(struct device *dev, + struct device_node *node) { const char *name; if (of_property_read_string(node, "label", &name) < 0) name = kbasename(node->full_name); - return kstrdup_const(name, GFP_KERNEL); + return devm_kstrdup_const(dev, name, GFP_KERNEL); } static int exynos_pd_probe(struct platform_device *pdev) @@ -115,15 +116,13 @@ static int exynos_pd_probe(struct platfo if (!pd) return -ENOMEM; - pd->pd.name = exynos_get_domain_name(np); + pd->pd.name = exynos_get_domain_name(dev, np); if (!pd->pd.name) return -ENOMEM; pd->base = of_iomap(np, 0); - if (!pd->base) { - kfree_const(pd->pd.name); + if (!pd->base) return -ENODEV; - } pd->pd.power_off = exynos_pd_power_off; pd->pd.power_on = exynos_pd_power_on;