From: Nathan Chancellor <nathan@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Jose Javier Rodriguez Barbarin
<dev-josejavier.rodriguez@duagon.com>,
andy@kernel.org, krzk@kernel.org, linus.walleij@linaro.org,
nsc@kernel.org, bleung@chromium.org,
heikki.krogerus@linux.intel.com, abhishekpandit@chromium.org,
masahiroy@kernel.org, legion@kernel.org, hughd@google.com,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@duagon.com>
Subject: Re: [PATCH v3] mcb: Add missing modpost build support
Date: Wed, 3 Dec 2025 13:27:21 -0700 [thread overview]
Message-ID: <20251203202721.GA3060476@ax162> (raw)
In-Reply-To: <2025120340-clubbing-stash-a933@gregkh>
On Wed, Dec 03, 2025 at 09:07:02AM +0100, Greg KH wrote:
> On Tue, Dec 02, 2025 at 01:34:21PM -0700, Nathan Chancellor wrote:
> > On Tue, Dec 02, 2025 at 09:42:00AM +0100, Jose Javier Rodriguez Barbarin wrote:
> > > mcb bus is not prepared to autoload client drivers with the data defined on
> > > the drivers' MODULE_DEVICE_TABLE. modpost cannot access to mcb_table_id
> > > inside MODULE_DEVICE_TABLE so the data declared inside is ignored.
> > >
> > > Add modpost build support for accessing to the mcb_table_id coded on device
> > > drivers' MODULE_DEVICE_TABLE.
> > >
> > > Fixes: 3764e82e5150 ("drivers: Introduce MEN Chameleon Bus")
> > > Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@duagon.com>
> > > Signed-off-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
> > > ---
> >
> > Acked-by: Nathan Chancellor <nathan@kernel.org>
> >
> > We should be able to get this to Linus by 6.19-rc1.
>
> Why? What's the rush?
I was going off of Andy's previous comments about getting this into a
6.19-rc release to allow Jose to send the follow up changes for removing
MODULE_ALIAS from the drivers that use mcb_device_id, which are spread
out across the tree.
https://lore.kernel.org/CAHp75VfhM5GuYY1qUKgBhePDo4oe5k3K1ZDTPbYJNr5NtjVVfQ@mail.gmail.com/
https://lore.kernel.org/aS3YUYtrEn39lUPl@smile.fi.intel.com/
That could be -rc2 or -rc3 obviously but -rc1 is objectively the most
compatible base for all maintainer trees.
> It should have been in -next already to get into -rc1.
This seems like a low risk change, maybe even a borderline fix (and it
would still be in -next before it went to Linus). I do not have to push
it that quickly though, I have no strong opinion on the priority of this
change. Another option would be a shared branch after -rc1 is out that
other trees could pull in so that those changes could go into 6.20 and
get proper -next soak time.
Cheers,
Nathan
next prev parent reply other threads:[~2025-12-03 20:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 8:42 [PATCH v3] mcb: Add missing modpost build support Jose Javier Rodriguez Barbarin
2025-12-02 14:37 ` Andy Shevchenko
2025-12-02 20:34 ` Nathan Chancellor
2025-12-03 8:07 ` Greg KH
2025-12-03 20:27 ` Nathan Chancellor [this message]
2025-12-27 20:10 ` Nicolas Schier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251203202721.GA3060476@ax162 \
--to=nathan@kernel.org \
--cc=abhishekpandit@chromium.org \
--cc=andy@kernel.org \
--cc=bleung@chromium.org \
--cc=dev-jorge.sanjuangarcia@duagon.com \
--cc=dev-josejavier.rodriguez@duagon.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hughd@google.com \
--cc=krzk@kernel.org \
--cc=legion@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nsc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.