From: Jakub Kicinski <kuba@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Shuah Khan <shuah@kernel.org>,
Christian Brauner <brauner@kernel.org>,
Elizabeth Figura <zfigura@codeweavers.com>,
Thomas Gleixner <tglx@linutronix.de>,
Eric Dumazet <edumazet@google.com>, Kees Cook <kees@kernel.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
wine-devel@winehq.org, netdev@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH 00/13] selftests: Fix problems seen when building with -Werror
Date: Thu, 4 Dec 2025 09:43:20 -0800 [thread overview]
Message-ID: <20251204094320.7d4429d1@kernel.org> (raw)
In-Reply-To: <536d47f4-25b1-430a-820d-c22eb8a92c80@roeck-us.net>
On Thu, 4 Dec 2025 09:16:16 -0800 Guenter Roeck wrote:
> On Thu, Dec 04, 2025 at 08:27:54AM -0800, Jakub Kicinski wrote:
> > On Thu, 4 Dec 2025 08:17:14 -0800 Guenter Roeck wrote:
> > > This series fixes build errors observed when trying to build selftests
> > > with -Werror.
> >
> > If your intention is to make -Werror the default please stop.
> > Defaulting WERROR to enabled is one of the silliest things we have done
> > in recent past.
>
> No, that is not the idea, and not the intention.
>
> The Google infrastructure builds the kernel, including selftests, with
> -Werror enabled. This triggers a number of build errors when trying to
> build selftests with the 6.18 kernel. That means I have three options:
> 1) Disable -Werror in selftest builds and accept that some real problems
> will slip through. Not really a good option, and not acceptable.
> 2) Fix the problems in the upstream kernel and backport.
> 3) Fix the problems downstream only. Not really a good option but I guess
> we'll have to do it if this series (and/or follow-up patches needed to
> support glibc older than 2.36) is rejected.
>
> We'll have to carry the patches downstream if 2) is rejected, but at
> the very least I wanted to give it a try.
Understood, of course we should fix the warnings!
If we're fixing warnings, tho, I wouldn't have mentioned -Werror in
the _subject_. It doesn't affect which warnings are enabled, AFAIK?
next prev parent reply other threads:[~2025-12-04 17:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 16:17 [PATCH 00/13] selftests: Fix problems seen when building with -Werror Guenter Roeck
2025-12-04 16:17 ` [PATCH 01/13] clone3: clone3_cap_checkpoint_restore: Fix build errors seen " Guenter Roeck
2025-12-04 16:17 ` [PATCH 02/13] selftests: ntsync: Fix build errors -seen " Guenter Roeck
2025-12-04 16:17 ` [PATCH 03/13] selftests/filesystems: fclog: Fix build errors seen " Guenter Roeck
2025-12-04 16:17 ` [PATCH 04/13] selftests/filesystems: file_stressor: Fix build error " Guenter Roeck
2025-12-04 16:17 ` [PATCH 05/13] selftests/filesystems: anon_inode_test: " Guenter Roeck
2025-12-04 16:17 ` [PATCH 06/13] selftest: af_unix: Support compilers without flex-array-member-not-at-end support Guenter Roeck
2025-12-04 17:40 ` Jakub Kicinski
2025-12-04 17:58 ` Guenter Roeck
2025-12-04 16:17 ` [PATCH 07/13] selftest/futex: Comment out test_futex_mpol Guenter Roeck
2025-12-04 16:17 ` [PATCH 08/13] selftests: net: netlink-dumps: Avoid uninitialized variable error Guenter Roeck
2025-12-04 16:17 ` [PATCH 09/13] selftests/seccomp: Fix build error seen with -Werror Guenter Roeck
2025-12-04 16:17 ` [PATCH 10/13] selftests: net: Work around " Guenter Roeck
2025-12-04 16:30 ` Jakub Kicinski
2025-12-04 17:21 ` Guenter Roeck
2025-12-04 16:17 ` [PATCH 11/13] selftests/fs/mount-notify: Fix build failure " Guenter Roeck
2025-12-04 16:17 ` [PATCH 12/13] selftests/fs/mount-notify-ns: Fix build failures " Guenter Roeck
2025-12-04 16:17 ` [PATCH 13/13] selftests: net: tfo: Fix build error " Guenter Roeck
2025-12-04 16:27 ` [PATCH 00/13] selftests: Fix problems seen when building " Jakub Kicinski
2025-12-04 17:16 ` Guenter Roeck
2025-12-04 17:43 ` Jakub Kicinski [this message]
2025-12-04 17:56 ` Guenter Roeck
2025-12-04 20:03 ` Kees Cook
2025-12-04 20:07 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251204094320.7d4429d1@kernel.org \
--to=kuba@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=edumazet@google.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=wine-devel@winehq.org \
--cc=zfigura@codeweavers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.