All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Artem Shimko <a.shimko.dev@gmail.com>
Cc: andi.shyti@kernel.org, andriy.shevchenko@linux.intel.com,
	jsd@semihalf.com, linux-i2c@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] i2c: designware: Replace magic numbers with named constants
Date: Thu, 4 Dec 2025 13:00:36 +0100	[thread overview]
Message-ID: <20251204120036.GC1613537@black.igk.intel.com> (raw)
In-Reply-To: <20251204114129.607200-1-a.shimko.dev@gmail.com>

On Thu, Dec 04, 2025 at 02:41:29PM +0300, Artem Shimko wrote:
> Replace various magic numbers with properly named constants to improve
> code readability and maintainability. This includes constants for
> register access, timing adjustments, timeouts, FIFO parameters,
> and default values.
> 
> The change makes the code more self-documenting without altering any
> functionality.
> 
> Signed-off-by: Artem Shimko <a.shimko.dev@gmail.com>
> ---
> 
> Hello maintainers and reviewers,
> 
> Fix replaces magic numbers throughout the DesignWare I2C driver with named 
> constants to improve code readability and maintainability.
> 
> The change introduces constants for register access, timing adjustments, 
> timeouts, FIFO parameters, and default values, all properly documented 
> with comments.
> 
> No functional changes.

There is already v3 at least of this patch. What changed?

Also can you please send new versions on a new thread instead of replying
on the existing one? It is really hard to follow.

  reply	other threads:[~2025-12-04 12:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-05 16:18 [PATCH] i2c: designware: Replace magic numbers with named constants Artem Shimko
2025-11-06 10:42 ` Mika Westerberg
2025-11-06 10:52   ` Andy Shevchenko
2025-11-06 11:09     ` Artem Shimko
2025-12-04 11:41       ` [PATCH v2] " Artem Shimko
2025-12-04 12:00         ` Mika Westerberg [this message]
2025-12-04 12:07           ` Artem Shimko
2025-12-04 12:12             ` Mika Westerberg
2025-12-04 14:40               ` Artem Shimko
2025-11-06 11:01   ` [PATCH] " Artem Shimko
  -- strict thread matches above, loose matches on Subject: below --
2025-11-06 16:02 [PATCH v2] " Artem Shimko
2025-11-07  6:54 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251204120036.GC1613537@black.igk.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=a.shimko.dev@gmail.com \
    --cc=andi.shyti@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=jsd@semihalf.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.