From: SeongJae Park <sj@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Quanmin Yan <yanquanmin1@huawei.com>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/damon/tests/core-kunit: avoid damos_test_commit stack warning
Date: Thu, 4 Dec 2025 07:01:50 -0800 [thread overview]
Message-ID: <20251204150151.83380-1-sj@kernel.org> (raw)
In-Reply-To: <20251204100403.1034980-1-arnd@kernel.org>
On Thu, 4 Dec 2025 11:03:54 +0100 Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly added damos_test_commit() constructs multiple large structures
> on the stack, which exceeds the warning limit in some cases:
>
> In file included from mm/damon/core.c:2941:
> mm/damon/tests/core-kunit.h: In function 'damos_test_commit':
> mm/damon/tests/core-kunit.h:965:1: error: the frame size of 1520 bytes is larger than 1280 bytes [-Werror=frame-larger-than=]
>
> Split this function up into two separate ones that are called sequentially,
> so they can occupy the same stack slots.
Thank you for catching and fixing this, Arnd!
>
> Fixes: 299a88f6ec13 ("mm/damon/tests/core-kunit: add damos_commit() test")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
[...]
prev parent reply other threads:[~2025-12-04 15:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 10:03 [PATCH] mm/damon/tests/core-kunit: avoid damos_test_commit stack warning Arnd Bergmann
2025-12-04 15:01 ` SeongJae Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251204150151.83380-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=yanquanmin1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.