From: Kees Cook <kees@kernel.org>
To: Val Packett <val@packett.cool>
Cc: Tony Luck <tony.luck@intel.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
Ard Biesheuvel <ardb@kernel.org>,
linux-hardening@vger.kernel.org, linux-efi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] efi: pstore: Support late setup with TEE-backed efivars ops
Date: Thu, 4 Dec 2025 15:36:08 -0800 [thread overview]
Message-ID: <202512041535.AA6065A38@keescook> (raw)
In-Reply-To: <20251203042850.14210-1-val@packett.cool>
On Wed, Dec 03, 2025 at 01:28:29AM -0300, Val Packett wrote:
> On some platforms, EFI variable services only become available when an
> appropriate TEE driver is initialized such as qseecom, gsmi or stmm.
>
> This would work fine when efi_pstore was built as a module and loaded
> late by userspace, but with CONFIG_EFI_VARS_PSTORE=y this driver would
> quit due to non-writable efivars before the necessary driver had any
> chance to load.
>
> Listen to efivar_ops_nh notifications and retry the initialization when
> writable EFI variable ops become available.
>
> Signed-off-by: Val Packett <val@packett.cool>
This seems fine to me, though I defer to Ard, who knows the EFI bits way
better than I do. :)
Acked-by: Kees Cook <kees@kernel.org>
--
Kees Cook
next prev parent reply other threads:[~2025-12-04 23:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 4:28 [PATCH] efi: pstore: Support late setup with TEE-backed efivars ops Val Packett
2025-12-04 9:49 ` Ilias Apalodimas
2025-12-04 20:57 ` Val Packett
2025-12-05 10:27 ` Ard Biesheuvel
2025-12-05 10:56 ` Ilias Apalodimas
2025-12-04 23:36 ` Kees Cook [this message]
2025-12-10 8:40 ` kernel test robot
2025-12-10 9:13 ` Ard Biesheuvel
2025-12-10 14:28 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202512041535.AA6065A38@keescook \
--to=kees@kernel.org \
--cc=ardb@kernel.org \
--cc=gpiccoli@igalia.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=val@packett.cool \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.