From: Nathan Chancellor <nathan@kernel.org>
To: Justin Stitt <justinstitt@google.com>
Cc: Marc Zyngier <maz@kernel.org>,
Oliver Upton <oliver.upton@linux.dev>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Joey Gouly <joey.gouly@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>, Will Deacon <will@kernel.org>,
Christopher Covington <cov@codeaurora.org>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, stable@vger.kernel.org
Subject: Re: [PATCH 6.1.y RESEND] KVM: arm64: silence -Wuninitialized-const-pointer warning
Date: Thu, 4 Dec 2025 17:22:45 -0700 [thread overview]
Message-ID: <20251205002245.GA3463270@ax162> (raw)
In-Reply-To: <2lse2swdqrovimdsakgtriadki2fsvikhuetjzxztoui5hpsai@6mmc64ugt22k>
On Thu, Dec 04, 2025 at 12:53:58PM -0800, Justin Stitt wrote:
> Quick correction:
>
> On Thu, Dec 04, 2025 at 12:50:11PM -0800, Justin Stitt wrote:
> > A new warning in Clang 22 [1] complains that @clidr passed to
> > get_clidr_el1() is an uninitialized const pointer. get_clidr_el1()
> > doesn't really care since it casts away the const-ness anyways.
> >
> > Silence the warning by initializing the struct.
> >
> > This patch won't apply to anything past v6.1 as this code section was
> > reworked in Commit 7af0c2534f4c ("KVM: arm64: Normalize cache
> > configuration"). There is no upstream equivalent so this patch only
> > needs to be applied (stable only) to 6.1.
> >
> > Cc: stable@vger.kernel.org
> > Fixes: 7c8c5e6a9101e ("arm64: KVM: system register handling")
> > Link: https://github.com/llvm/llvm-project/commit/00dacf8c22f065cb52efb14cd091d441f19b319e [1]
> > Signed-off-by: Justin Stitt <justinstitt@google.com>
> > ---
> > Resending this with Nathan's RB tag, an updated commit log and better
> > recipients from checkpatch.pl.
>
> My usage of $ b4 trailers must've not been correct because this 6.1
> version didn't pick up Nathan's RB tag. Whoops! Hopefully whoever picks
> this up can add that for me :)
Looks like you resent the first iteration of this change [1] instead of
the second [2], hence why 'b4 trailers -u' did not work, since I never
reviewed the first iteration after Marc rejected it :)
Your 5.15 resend looks correct though.
[1]: https://lore.kernel.org/20250724-b4-clidr-unint-const-ptr-v1-1-67c4d620b6b6@google.com/
[2]: https://lore.kernel.org/20250728-stable-disable-unit-ptr-warn-v1-1-958be9b66520@google.com/
Cheers,
Nathan
next prev parent reply other threads:[~2025-12-05 0:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 20:50 [PATCH 6.1.y RESEND] KVM: arm64: silence -Wuninitialized-const-pointer warning Justin Stitt
2025-12-04 20:53 ` Justin Stitt
2025-12-05 0:22 ` Nathan Chancellor [this message]
2025-12-05 22:53 ` Justin Stitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251205002245.GA3463270@ax162 \
--to=nathan@kernel.org \
--cc=alexandru.elisei@arm.com \
--cc=catalin.marinas@arm.com \
--cc=cov@codeaurora.org \
--cc=joey.gouly@arm.com \
--cc=justinstitt@google.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=stable@vger.kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.