From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v2 1/2] drm: Introduce drm_crtc_vblank_prepare()
Date: Fri, 5 Dec 2025 11:17:48 +0800 [thread overview]
Message-ID: <202512051120.3HWHmkDI-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20251201231807.287414-1-sunpeng.li@amd.com>
References: <20251201231807.287414-1-sunpeng.li@amd.com>
TO: sunpeng.li@amd.com
TO: amd-gfx@lists.freedesktop.org
TO: dri-devel@lists.freedesktop.org
CC: Harry.Wentland@amd.com
CC: Nicholas.Kazlauskas@amd.com
CC: simona@ffwll.ch
CC: airlied@gmail.com
CC: Leo Li <sunpeng.li@amd.com>
Hi,
kernel test robot noticed the following build warnings:
[auto build test WARNING on drm-i915/for-linux-next-fixes]
[also build test WARNING on daeinki-drm-exynos/exynos-drm-next v6.18]
[cannot apply to drm-misc/drm-misc-next drm/drm-next drm-i915/for-linux-next drm-tip/drm-tip linus/master next-20251204]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/sunpeng-li-amd-com/drm-amd-display-Implement-prepare_vblank_enable-callback/20251202-072501
base: https://gitlab.freedesktop.org/drm/i915/kernel.git for-linux-next-fixes
patch link: https://lore.kernel.org/r/20251201231807.287414-1-sunpeng.li%40amd.com
patch subject: [PATCH v2 1/2] drm: Introduce drm_crtc_vblank_prepare()
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
config: nios2-randconfig-r071-20251204 (https://download.01.org/0day-ci/archive/20251205/202512051120.3HWHmkDI-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 8.5.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202512051120.3HWHmkDI-lkp@intel.com/
smatch warnings:
drivers/gpu/drm/drm_vblank.c:1527 drm_crtc_vblank_on_config() warn: variable dereferenced before check 'crtc' (see line 1519)
vim +/crtc +1527 drivers/gpu/drm/drm_vblank.c
ed20151a7699bb Ville Syrjälä 2018-11-27 1502
3ed4351a83ca05 Simona Vetter 2017-05-31 1503 /**
0d5040e406d2c4 Hamza Mahfooz 2024-07-25 1504 * drm_crtc_vblank_on_config - enable vblank events on a CRTC with custom
0d5040e406d2c4 Hamza Mahfooz 2024-07-25 1505 * configuration options
3ed4351a83ca05 Simona Vetter 2017-05-31 1506 * @crtc: CRTC in question
0d5040e406d2c4 Hamza Mahfooz 2024-07-25 1507 * @config: Vblank configuration value
3ed4351a83ca05 Simona Vetter 2017-05-31 1508 *
0d5040e406d2c4 Hamza Mahfooz 2024-07-25 1509 * See drm_crtc_vblank_on(). In addition, this function allows you to provide a
0d5040e406d2c4 Hamza Mahfooz 2024-07-25 1510 * custom vblank configuration for a given CRTC.
0d5040e406d2c4 Hamza Mahfooz 2024-07-25 1511 *
0d5040e406d2c4 Hamza Mahfooz 2024-07-25 1512 * Note that @config is copied, the pointer does not need to stay valid beyond
0d5040e406d2c4 Hamza Mahfooz 2024-07-25 1513 * this function call. For details of the parameters see
0d5040e406d2c4 Hamza Mahfooz 2024-07-25 1514 * struct drm_vblank_crtc_config.
3ed4351a83ca05 Simona Vetter 2017-05-31 1515 */
0d5040e406d2c4 Hamza Mahfooz 2024-07-25 1516 void drm_crtc_vblank_on_config(struct drm_crtc *crtc,
0d5040e406d2c4 Hamza Mahfooz 2024-07-25 1517 const struct drm_vblank_crtc_config *config)
3ed4351a83ca05 Simona Vetter 2017-05-31 1518 {
3ed4351a83ca05 Simona Vetter 2017-05-31 @1519 struct drm_device *dev = crtc->dev;
3ed4351a83ca05 Simona Vetter 2017-05-31 1520 unsigned int pipe = drm_crtc_index(crtc);
d12e36494dc2bf Ville Syrjälä 2024-04-08 1521 struct drm_vblank_crtc *vblank = drm_crtc_vblank_crtc(crtc);
38bd1e412d0aa4 Leo Li 2025-12-01 1522 int ret;
3ed4351a83ca05 Simona Vetter 2017-05-31 1523
5a4784f49b2dcf Sam Ravnborg 2020-05-23 1524 if (drm_WARN_ON(dev, pipe >= dev->num_crtcs))
3ed4351a83ca05 Simona Vetter 2017-05-31 1525 return;
3ed4351a83ca05 Simona Vetter 2017-05-31 1526
38bd1e412d0aa4 Leo Li 2025-12-01 @1527 if (crtc) {
38bd1e412d0aa4 Leo Li 2025-12-01 1528 ret = drm_crtc_vblank_prepare(crtc);
38bd1e412d0aa4 Leo Li 2025-12-01 1529 drm_WARN_ON(dev, ret);
38bd1e412d0aa4 Leo Li 2025-12-01 1530 if (ret)
38bd1e412d0aa4 Leo Li 2025-12-01 1531 return;
38bd1e412d0aa4 Leo Li 2025-12-01 1532 }
38bd1e412d0aa4 Leo Li 2025-12-01 1533
92cc68e35863c1 Lyude Paul 2020-07-20 1534 spin_lock_irq(&dev->vbl_lock);
02149a76d32bd8 Sam Ravnborg 2020-05-23 1535 drm_dbg_vbl(dev, "crtc %d, vblank enabled %d, inmodeset %d\n",
3ed4351a83ca05 Simona Vetter 2017-05-31 1536 pipe, vblank->enabled, vblank->inmodeset);
3ed4351a83ca05 Simona Vetter 2017-05-31 1537
0d5040e406d2c4 Hamza Mahfooz 2024-07-25 1538 vblank->config = *config;
0d5040e406d2c4 Hamza Mahfooz 2024-07-25 1539
3ed4351a83ca05 Simona Vetter 2017-05-31 1540 /* Drop our private "prevent drm_vblank_get" refcount */
3ed4351a83ca05 Simona Vetter 2017-05-31 1541 if (vblank->inmodeset) {
3ed4351a83ca05 Simona Vetter 2017-05-31 1542 atomic_dec(&vblank->refcount);
3ed4351a83ca05 Simona Vetter 2017-05-31 1543 vblank->inmodeset = 0;
3ed4351a83ca05 Simona Vetter 2017-05-31 1544 }
3ed4351a83ca05 Simona Vetter 2017-05-31 1545
3ed4351a83ca05 Simona Vetter 2017-05-31 1546 drm_reset_vblank_timestamp(dev, pipe);
3ed4351a83ca05 Simona Vetter 2017-05-31 1547
3ed4351a83ca05 Simona Vetter 2017-05-31 1548 /*
3ed4351a83ca05 Simona Vetter 2017-05-31 1549 * re-enable interrupts if there are users left, or the
3ed4351a83ca05 Simona Vetter 2017-05-31 1550 * user wishes vblank interrupts to be enabled all the time.
3ed4351a83ca05 Simona Vetter 2017-05-31 1551 */
0d5040e406d2c4 Hamza Mahfooz 2024-07-25 1552 if (atomic_read(&vblank->refcount) != 0 || !vblank->config.offdelay_ms)
5a4784f49b2dcf Sam Ravnborg 2020-05-23 1553 drm_WARN_ON(dev, drm_vblank_enable(dev, pipe));
92cc68e35863c1 Lyude Paul 2020-07-20 1554 spin_unlock_irq(&dev->vbl_lock);
3ed4351a83ca05 Simona Vetter 2017-05-31 1555 }
0d5040e406d2c4 Hamza Mahfooz 2024-07-25 1556 EXPORT_SYMBOL(drm_crtc_vblank_on_config);
0d5040e406d2c4 Hamza Mahfooz 2024-07-25 1557
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2025-12-05 3:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 3:17 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-12-04 3:46 [PATCH v2 1/2] drm: Introduce drm_crtc_vblank_prepare() kernel test robot
2025-12-04 8:25 ` Dan Carpenter
2025-12-01 23:18 sunpeng.li
2025-12-08 15:43 ` Harry Wentland
2025-12-09 10:05 ` Jani Nikula
2025-12-09 10:47 ` Ville Syrjälä
2025-12-10 17:55 ` Leo Li
2026-01-02 22:45 ` Leo Li
2025-12-10 17:26 ` Leo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202512051120.3HWHmkDI-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.